[patch repost] AC_ARG_PROGRAM for gdbserver

[patch repost] AC_ARG_PROGRAM for gdbserver

[Aron Griffis]

Hello,

I originally sent this 10 days ago.  I don't mind being patient, but
since there was no acknowledgement I'm not sure that it was not lost
in somebody's inbox.  On the other hand, if you see something wrong
with the patch, please let me know and I'll be happy to investigate
and post a new patch.

Regards,
Aron

----

Hello,

gdbserver/configure.ac is missing AC_ARG_PROGRAM.  As a result, the
program_transform_name substitution fails because $ is not doubled in
the Makefile:

  make[3]: Entering directory `/opt/toolchain/amd64/obj/upstream/gdb-6.3/gdb/gdbserver'
  n=`echo gdbserver | sed 's,-6.3,; '`; \  <<--- note incorrect sed expression
  ...
  sed: -e expression #1, char 9: Unterminated `s' command

I've provided two patches, one against HEAD and the other against 6.3
(uses configure.in instead of configure.ac) which should probably also
be fixed since it's likely people would want to use
program_transform_name as new versions are released.

Regards,
Aron


--- gdb/gdb/gdbserver/ChangeLog.agriffis	2005-01-07 16:53:22.000000000 -0500
+++ gdb/gdb/gdbserver/ChangeLog	2005-02-12 11:59:28.300315705 -0500
@@ -1,3 +1,8 @@
+2005-02-12  Aron Griffis  <agriffis@toolchain.org>
+
+	* configure.ac: Add AC_ARG_PROGRAM so that
+	--program-transform-name and friends work correctly
+
 2005-01-07  Andrew Cagney  <cagney@gnu.org>
 
 	* configure.ac: Rename configure.in, require autoconf 2.59.
--- gdb/gdb/gdbserver/configure.ac.agriffis	2005-02-12 11:21:10.000000000 -0500
+++ gdb/gdb/gdbserver/configure.ac	2005-02-12 11:21:15.536102522 -0500
@@ -40,6 +40,8 @@
 
 . ${srcdir}/configure.srv
 
+AC_ARG_PROGRAM
+
 if test "${srv_linux_usrregs}" = "yes"; then
   AC_DEFINE(HAVE_LINUX_USRREGS)
 fi


--- gdb-6.3/gdb/gdbserver/ChangeLog.agriffis	2005-02-12 12:02:35.000000000 -0500
+++ gdb-6.3/gdb/gdbserver/ChangeLog	2005-02-12 12:03:40.511528592 -0500
@@ -1,3 +1,8 @@
+2005-02-12  Aron Griffis  <agriffis@toolchain.org>
+
+	* configure.in: Add AC_ARG_PROGRAM so that
+	--program-transform-name and friends work correctly
+
 2004-10-21  Joel Brobecker  <brobecker@gnat.com>
 
 	* linux-x86-64-low.c (ARCH_SET_GS): Add definition if missing.
--- gdb-6.3/gdb/gdbserver/configure.in.agriffis	2004-10-16 12:18:54.000000000 -0400
+++ gdb-6.3/gdb/gdbserver/configure.in	2005-02-12 11:17:22.585667917 -0500
@@ -38,6 +38,8 @@
 
 . ${srcdir}/configure.srv
 
+AC_ARG_PROGRAM
+
 if test "${srv_linux_usrregs}" = "yes"; then
   AC_DEFINE(HAVE_LINUX_USRREGS)
 fi

Re: [patch repost] AC_ARG_PROGRAM for gdbserver

[Daniel Jacobowitz]

On Tue, Feb 22, 2005 at 06:11:08PM -0500, Aron Griffis wrote:
> Hello,
> 
> I originally sent this 10 days ago.  I don't mind being patient, but
> since there was no acknowledgement I'm not sure that it was not lost
> in somebody's inbox.  On the other hand, if you see something wrong
> with the patch, please let me know and I'll be happy to investigate
> and post a new patch.
> 
> Regards,
> Aron
> 
> ----
> 
> Hello,
> 
> gdbserver/configure.ac is missing AC_ARG_PROGRAM.  As a result, the
> program_transform_name substitution fails because $ is not doubled in
> the Makefile:
> 
>   make[3]: Entering directory `/opt/toolchain/amd64/obj/upstream/gdb-6.3/gdb/gdbserver'
>   n=`echo gdbserver | sed 's,-6.3,; '`; \  <<--- note incorrect sed expression
>   ...
>   sed: -e expression #1, char 9: Unterminated `s' command
> 
> I've provided two patches, one against HEAD and the other against 6.3
> (uses configure.in instead of configure.ac) which should probably also
> be fixed since it's likely people would want to use
> program_transform_name as new versions are released.

I don't quite follow the logic of your last statement.  Since there are
no planned releases from the 6.3 branch, I'm not going to apply it
there.

Otherwise, the patch is obviously correct and I've applied it to HEAD.
I needed some unrelated changes in order to regenerate configure from
configure.ac correctly.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

2005-02-24  Daniel Jacobowitz  <dan@codesourcery.com>

	* acinclude.m4: Include bfd/bfd.m4 directly.
	* configure.ac: Use AC_ARG_PROGRAM.  Suggested by Aron Griffis
	<agriffis@toolchain.org>.
	* aclocal.m4, configure: Regenerated.

Index: acinclude.m4
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/acinclude.m4,v
retrieving revision 1.2
diff -u -p -r1.2 acinclude.m4
--- acinclude.m4	8 Dec 2004 15:50:29 -0000	1.2
+++ acinclude.m4	24 Feb 2005 20:25:05 -0000
@@ -1,5 +1,5 @@
 dnl gdb/gdbserver/configure.in uses BFD_HAVE_SYS_PROCFS_TYPE.
-sinclude(../../bfd/acinclude.m4)
+sinclude(../../bfd/bfd.m4)
 
 AC_DEFUN([SRV_CHECK_THREAD_DB],
 [AC_CACHE_CHECK([for libthread_db],[srv_cv_thread_db],
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v
retrieving revision 1.1
diff -u -p -r1.1 configure.ac
--- configure.ac	7 Jan 2005 21:53:23 -0000	1.1
+++ configure.ac	24 Feb 2005 20:25:05 -0000
@@ -1,5 +1,5 @@
 dnl Autoconf configure script for GDB server.
-dnl Copyright 2000, 2002, 2003, 2004 Free Software Foundation, Inc.
+dnl Copyright 2000, 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
 dnl
 dnl This file is part of GDB.
 dnl
@@ -30,6 +30,8 @@ AC_CANONICAL_SYSTEM
 
 AC_PROG_INSTALL
 
+AC_ARG_PROGRAM
+
 AC_HEADER_STDC
 
 AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h string.h dnl

Re: [patch repost] AC_ARG_PROGRAM for gdbserver

[Aron Griffis]

Daniel Jacobowitz wrote:	[Thu Feb 24 2005, 03:26:58PM EST]
> On Tue, Feb 22, 2005 at 06:11:08PM -0500, Aron Griffis wrote:
> > I've provided two patches, one against HEAD and the other against 6.3
> > (uses configure.in instead of configure.ac) which should probably also
> > be fixed since it's likely people would want to use
> > program_transform_name as new versions are released.
> 
> I don't quite follow the logic of your last statement.  Since there are
> no planned releases from the 6.3 branch, I'm not going to apply it
> there.

No problem, my suggestion just reflects my unfamiliarity with the gdb
release process and schedule.  Locally I've been building gdb-6.3 with
--program-suffix=-6.3 so that I could have more than one version
installed.  But gdbserver installs as /usr/bin/gdbserver instead of
/usr/bin/gdbserver-6.3; I'll just apply the patch locally to work
around the problem.

> Otherwise, the patch is obviously correct and I've applied it to HEAD.
> I needed some unrelated changes in order to regenerate configure from
> configure.ac correctly.

Great, thanks.

Regards,
Aron