From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24849 invoked by alias); 22 Feb 2005 23:12:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24761 invoked from network); 22 Feb 2005 23:12:17 -0000 Received: from unknown (HELO atlrel6.hp.com) (156.153.255.205) by sourceware.org with SMTP; 22 Feb 2005 23:12:17 -0000 Received: from smtp1.fc.hp.com (smtp1.fc.hp.com [15.15.136.127]) by atlrel6.hp.com (Postfix) with ESMTP id C64526A54 for ; Tue, 22 Feb 2005 18:12:16 -0500 (EST) Received: from ldl.fc.hp.com (ldl.fc.hp.com [15.11.146.30]) by smtp1.fc.hp.com (Postfix) with ESMTP id 5622038047 for ; Tue, 22 Feb 2005 16:12:16 -0700 (MST) Received: from localhost (localhost [127.0.0.1]) by ldl.fc.hp.com (Postfix) with ESMTP id 25B75134121 for ; Tue, 22 Feb 2005 16:12:16 -0700 (MST) Received: from ldl.fc.hp.com ([127.0.0.1]) by localhost (ldl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25594-09 for ; Tue, 22 Feb 2005 16:12:15 -0700 (MST) Received: by ldl.fc.hp.com (Postfix, from userid 11276) id 3FE26134120; Tue, 22 Feb 2005 16:12:15 -0700 (MST) X-IMAP-Sender: agriffis Date: Wed, 23 Feb 2005 16:11:00 -0000 X-OfflineIMAP-2092711681-6c646c73656e64-494e424f582e4f7574626f78: 1109113935-0307531708288-v4.0.8 From: Aron Griffis To: gdb-patches@sources.redhat.com Subject: [patch repost] AC_ARG_PROGRAM for gdbserver Message-ID: <20050222231108.GD3648@kaf.zko.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.6i X-SW-Source: 2005-02/txt/msg00244.txt.bz2 Hello, I originally sent this 10 days ago. I don't mind being patient, but since there was no acknowledgement I'm not sure that it was not lost in somebody's inbox. On the other hand, if you see something wrong with the patch, please let me know and I'll be happy to investigate and post a new patch. Regards, Aron ---- Hello, gdbserver/configure.ac is missing AC_ARG_PROGRAM. As a result, the program_transform_name substitution fails because $ is not doubled in the Makefile: make[3]: Entering directory `/opt/toolchain/amd64/obj/upstream/gdb-6.3/gdb/gdbserver' n=`echo gdbserver | sed 's,-6.3,; '`; \ <<--- note incorrect sed expression ... sed: -e expression #1, char 9: Unterminated `s' command I've provided two patches, one against HEAD and the other against 6.3 (uses configure.in instead of configure.ac) which should probably also be fixed since it's likely people would want to use program_transform_name as new versions are released. Regards, Aron --- gdb/gdb/gdbserver/ChangeLog.agriffis 2005-01-07 16:53:22.000000000 -0500 +++ gdb/gdb/gdbserver/ChangeLog 2005-02-12 11:59:28.300315705 -0500 @@ -1,3 +1,8 @@ +2005-02-12 Aron Griffis + + * configure.ac: Add AC_ARG_PROGRAM so that + --program-transform-name and friends work correctly + 2005-01-07 Andrew Cagney * configure.ac: Rename configure.in, require autoconf 2.59. --- gdb/gdb/gdbserver/configure.ac.agriffis 2005-02-12 11:21:10.000000000 -0500 +++ gdb/gdb/gdbserver/configure.ac 2005-02-12 11:21:15.536102522 -0500 @@ -40,6 +40,8 @@ . ${srcdir}/configure.srv +AC_ARG_PROGRAM + if test "${srv_linux_usrregs}" = "yes"; then AC_DEFINE(HAVE_LINUX_USRREGS) fi --- gdb-6.3/gdb/gdbserver/ChangeLog.agriffis 2005-02-12 12:02:35.000000000 -0500 +++ gdb-6.3/gdb/gdbserver/ChangeLog 2005-02-12 12:03:40.511528592 -0500 @@ -1,3 +1,8 @@ +2005-02-12 Aron Griffis + + * configure.in: Add AC_ARG_PROGRAM so that + --program-transform-name and friends work correctly + 2004-10-21 Joel Brobecker * linux-x86-64-low.c (ARCH_SET_GS): Add definition if missing. --- gdb-6.3/gdb/gdbserver/configure.in.agriffis 2004-10-16 12:18:54.000000000 -0400 +++ gdb-6.3/gdb/gdbserver/configure.in 2005-02-12 11:17:22.585667917 -0500 @@ -38,6 +38,8 @@ . ${srcdir}/configure.srv +AC_ARG_PROGRAM + if test "${srv_linux_usrregs}" = "yes"; then AC_DEFINE(HAVE_LINUX_USRREGS) fi