[patch repost] AC_ARG_PROGRAM for gdbserver

Aron Griffis
2005-02-22T23:12:28Z

Hello,

I originally sent this 10 days ago. I don't mind being patient, but
since there was no acknowledgement I'm not sure that it was not lost
in somebody's inbox. On the other hand, if you see something wrong
with the patch, please let me know and I'll be happy to investigate
and post a new patch.

Regards,
Aron

----

Hello,

gdbserver/configure.ac is missing AC_ARG_PROGRAM. As a result, the
program_transform_name substitution fails because $ is not doubled in
the Makefile:

make[3]: Entering directory `/opt/toolchain/amd64/obj/upstream/gdb-6.3/gdb/gdbserver'
n=`echo gdbserver | sed 's,-6.3,; '`; \ <<--- note incorrect sed expression
...
sed: -e expression #1, char 9: Unterminated `s' command

I've provided two patches, one against HEAD and the other against 6.3
(uses configure.in instead of configure.ac) which should probably also
be fixed since it's likely people would want to use
program_transform_name as new versions are released.

Regards,
Aron

--- gdb/gdb/gdbserver/ChangeLog.agriffis 2005-01-07 16:53:22.000000000 -0500
+++ gdb/gdb/gdbserver/ChangeLog 2005-02-12 11:59:28.300315705 -0500
@@ -1,3 +1,8 @@
+2005-02-12 Aron Griffis <agriffis@toolchain.org>
+
+ * configure.ac: Add AC_ARG_PROGRAM so that
+ --program-transform-name and friends work correctly
+
2005-01-07 Andrew Cagney <cagney@gnu.org>

* configure.ac: Rename configure.in, require autoconf 2.59.
--- gdb/gdb/gdbserver/configure.ac.agriffis 2005-02-12 11:21:10.000000000 -0500
+++ gdb/gdb/gdbserver/configure.ac 2005-02-12 11:21:15.536102522 -0500
@@ -40,6 +40,8 @@

. ${srcdir}/configure.srv

+AC_ARG_PROGRAM
+
if test "${srv_linux_usrregs}" = "yes"; then
AC_DEFINE(HAVE_LINUX_USRREGS)
fi

--- gdb-6.3/gdb/gdbserver/ChangeLog.agriffis 2005-02-12 12:02:35.000000000 -0500
+++ gdb-6.3/gdb/gdbserver/ChangeLog 2005-02-12 12:03:40.511528592 -0500
@@ -1,3 +1,8 @@
+2005-02-12 Aron Griffis <agriffis@toolchain.org>
+
+ * configure.in: Add AC_ARG_PROGRAM so that
+ --program-transform-name and friends work correctly
+
2004-10-21 Joel Brobecker <brobecker@gnat.com>

* linux-x86-64-low.c (ARCH_SET_GS): Add definition if missing.
--- gdb-6.3/gdb/gdbserver/configure.in.agriffis 2004-10-16 12:18:54.000000000 -0400
+++ gdb-6.3/gdb/gdbserver/configure.in 2005-02-12 11:17:22.585667917 -0500
@@ -38,6 +38,8 @@

. ${srcdir}/configure.srv

+AC_ARG_PROGRAM
+
if test "${srv_linux_usrregs}" = "yes"; then
AC_DEFINE(HAVE_LINUX_USRREGS)
fi