Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name
Date: Wed, 01 Dec 2004 03:05:00 -0000	[thread overview]
Message-ID: <20041201030522.GF1204@adacore.com> (raw)
In-Reply-To: <16810.33923.904081.661032@localhost.redhat.com>

>  > > 2004-10-22  Joel Brobecker  <brobecker@gnat.com>
>  > >         
>  > >         From Paul Hilfinger <hilfinger@gnat.com>
>  > >         * dwarf2read.c (new_symbol): Use SYMBOL_SEARCH_NAME rather than
>  > >         SYMBOL_NATURAL_NAME to set type names.

> Sigh, this is a hack on top af another.  Unfortunately the initial
> review of the symtab Ada changes wasn't helpful.  I have no choice but
> to let this go in for now, however, please, start thinking of a way to
> get rid of those special cases in SYMBOL_blah_NAME.  Making those
> become part of the language vector comes to mind.

OK, I see Paul, who is the one who knows most about these symbol names
issues, has already answered, so I won't comment on that (I didn't have
much to say anyway :-).

> Can you come up with a test case for gdb.ada that shows the problem,
> and is cured by this patch?

Yes, I think so. I will commit a testcase and then commit this change.
Thanks for your review.

-- 
Joel


  parent reply	other threads:[~2004-12-01  3:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 21:39 Joel Brobecker
2004-11-01 19:50 ` Joel Brobecker
2004-11-29  2:12   ` Elena Zannoni
2004-11-29 19:54     ` Paul Hilfinger
2004-12-01  3:05     ` Joel Brobecker [this message]
2005-02-15 20:24       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041201030522.GF1204@adacore.com \
    --to=brobecker@adacore.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox