From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name
Date: Mon, 01 Nov 2004 19:50:00 -0000 [thread overview]
Message-ID: <20041101195035.GJ27334@gnat.com> (raw)
In-Reply-To: <20041022213911.GJ21300@gnat.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
With the patch, I think I have a better change of getting a review...
On Fri, Oct 22, 2004 at 02:39:11PM -0700, Joel Brobecker wrote:
> Right now, new_symbol() in dwarf2read.c sometimes sets the type name
> using the SYMBOL_NATURAL_NAME. This is causing problems with Ada,
> because contrary to C++ or Java, we chose to perform our searches using
> the mangled name, not the demangled one.
>
> 2004-10-22 Joel Brobecker <brobecker@gnat.com>
>
> From Paul Hilfinger <hilfinger@gnat.com>
> * dwarf2read.c (new_symbol): Use SYMBOL_SEARCH_NAME rather than
> SYMBOL_NATURAL_NAME to set type names.
>
> Tested on x86-linux. No regression.
> OK to apply?
--
Joel
[-- Attachment #2: dwarf2read.c.diff --]
[-- Type: text/plain, Size: 657 bytes --]
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.168
diff -u -p -r1.168 dwarf2read.c
--- dwarf2read.c 19 Oct 2004 20:28:56 -0000 1.168
+++ dwarf2read.c 1 Nov 2004 19:49:49 -0000
@@ -6922,7 +6922,7 @@ new_symbol (struct die_info *die, struct
this objfile, so we don't need to duplicate it for
the type. */
if (TYPE_NAME (SYMBOL_TYPE (sym)) == 0)
- TYPE_NAME (SYMBOL_TYPE (sym)) = SYMBOL_NATURAL_NAME (sym);
+ TYPE_NAME (SYMBOL_TYPE (sym)) = SYMBOL_SEARCH_NAME (sym);
add_symbol_to_list (typedef_sym, list_to_add);
}
}
next prev parent reply other threads:[~2004-11-01 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 21:39 Joel Brobecker
2004-11-01 19:50 ` Joel Brobecker [this message]
2004-11-29 2:12 ` Elena Zannoni
2004-11-29 19:54 ` Paul Hilfinger
2004-12-01 3:05 ` Joel Brobecker
2005-02-15 20:24 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101195035.GJ27334@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox