Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Hilfinger <hilfingr@EECS.Berkeley.EDU>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: Joel Brobecker <brobecker@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name
Date: Mon, 29 Nov 2004 19:54:00 -0000	[thread overview]
Message-ID: <200411291953.iATJrjTP002703@tully.CS.Berkeley.EDU> (raw)
In-Reply-To: Message from Elena Zannoni <ezannoni@redhat.com>  of "Sun, 28 Nov 2004 21:08:03 EST." <16810.33923.904081.661032@localhost.redhat.com>


From hilfingr  Mon Nov 29 11:29:06 2004
Date: Mon, 29 Nov 2004 01:45:26 -0800
From: "Paul N. Hilfinger" <hilfingr@otisco.mckusick.com>
To: hilfingr@EECS.Berkeley.EDU
Reply-to: Hilfinger@otisco.mckusick.com
X-BTI-AntiSpam: sta:false/3/021,dcc:passed,rbl:off,wlbl:none
References: <200411290224.iAT2OHrd029832@tully.CS.Berkeley.EDU>
Original-recipient: rfc822;hilfingr@imap4.CS.Berkeley.EDU



> Sigh, this is a hack on top af another.  Unfortunately the initial
> review of the symtab Ada changes wasn't helpful.  I have no choice but
> to let this go in for now, however, please, start thinking of a way to
> get rid of those special cases in SYMBOL_blah_NAME.  Making those
> become part of the language vector comes to mind.

Elena,

Would you perhaps elaborate on this critique a bit?
SYMBOL_SEARCH_NAME is, by definition, the name by which a client (in
this case, a language module) looks up an entity, so it would seem
appropriate for this context.

Is your concern that SYMBOL_SEARCH_NAME (and the other SYMBOL_*_NAMEs,
for that matter) involve language-specific tests in their
implementations---i.e., that they are not properly object-orientized?
This of course is a long-standing blotch.  If you think it important,
I could fix it (for Ada and C++) as you suggest with some additions to
the language vector.  The only annoyance here is that we'd then want to
introduce a new fast mapping from 

	  enum language => struct language_defn * 

rather than using the current definition of
language_def (which does a lookup).

Paul


  reply	other threads:[~2004-11-29 19:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 21:39 Joel Brobecker
2004-11-01 19:50 ` Joel Brobecker
2004-11-29  2:12   ` Elena Zannoni
2004-11-29 19:54     ` Paul Hilfinger [this message]
2004-12-01  3:05     ` Joel Brobecker
2005-02-15 20:24       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411291953.iATJrjTP002703@tully.CS.Berkeley.EDU \
    --to=hilfingr@eecs.berkeley.edu \
    --cc=brobecker@gnat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox