From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10750 invoked by alias); 29 Nov 2004 19:54:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10714 invoked from network); 29 Nov 2004 19:53:53 -0000 Received: from unknown (HELO tully.CS.Berkeley.EDU) (128.32.153.227) by sourceware.org with SMTP; 29 Nov 2004 19:53:53 -0000 Received: from tully.CS.Berkeley.EDU (localhost [127.0.0.1]) by tully.CS.Berkeley.EDU (8.12.7/8.12.7/3.141592645) with ESMTP id iATJrku1002706; Mon, 29 Nov 2004 11:53:46 -0800 (PST) Received: from tully.CS.Berkeley.EDU (hilfingr@localhost) by tully.CS.Berkeley.EDU (8.12.7/8.12.7/Submit) with ESMTP id iATJrjTP002703; Mon, 29 Nov 2004 11:53:45 -0800 (PST) Message-Id: <200411291953.iATJrjTP002703@tully.CS.Berkeley.EDU> To: Elena Zannoni cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name In-Reply-To: Message from Elena Zannoni of "Sun, 28 Nov 2004 21:08:03 EST." <16810.33923.904081.661032@localhost.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2699.1101758025.1@tully.CS.Berkeley.EDU> Date: Mon, 29 Nov 2004 19:54:00 -0000 From: Paul Hilfinger X-SW-Source: 2004-11/txt/msg00525.txt.bz2 >From hilfingr Mon Nov 29 11:29:06 2004 Date: Mon, 29 Nov 2004 01:45:26 -0800 From: "Paul N. Hilfinger" To: hilfingr@EECS.Berkeley.EDU Reply-to: Hilfinger@otisco.mckusick.com X-BTI-AntiSpam: sta:false/3/021,dcc:passed,rbl:off,wlbl:none References: <200411290224.iAT2OHrd029832@tully.CS.Berkeley.EDU> Original-recipient: rfc822;hilfingr@imap4.CS.Berkeley.EDU > Sigh, this is a hack on top af another. Unfortunately the initial > review of the symtab Ada changes wasn't helpful. I have no choice but > to let this go in for now, however, please, start thinking of a way to > get rid of those special cases in SYMBOL_blah_NAME. Making those > become part of the language vector comes to mind. Elena, Would you perhaps elaborate on this critique a bit? SYMBOL_SEARCH_NAME is, by definition, the name by which a client (in this case, a language module) looks up an entity, so it would seem appropriate for this context. Is your concern that SYMBOL_SEARCH_NAME (and the other SYMBOL_*_NAMEs, for that matter) involve language-specific tests in their implementations---i.e., that they are not properly object-orientized? This of course is a long-standing blotch. If you think it important, I could fix it (for Ada and C++) as you suggest with some additions to the language vector. The only annoyance here is that we'd then want to introduce a new fast mapping from enum language => struct language_defn * rather than using the current definition of language_def (which does a lookup). Paul