From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17113 invoked by alias); 1 Nov 2004 19:50:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17093 invoked from network); 1 Nov 2004 19:50:39 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 1 Nov 2004 19:50:39 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id A128747D9F; Mon, 1 Nov 2004 11:50:35 -0800 (PST) Date: Mon, 01 Nov 2004 19:50:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name Message-ID: <20041101195035.GJ27334@gnat.com> References: <20041022213911.GJ21300@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="zS7rBR6csb6tI2e1" Content-Disposition: inline In-Reply-To: <20041022213911.GJ21300@gnat.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-11/txt/msg00021.txt.bz2 --zS7rBR6csb6tI2e1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 699 With the patch, I think I have a better change of getting a review... On Fri, Oct 22, 2004 at 02:39:11PM -0700, Joel Brobecker wrote: > Right now, new_symbol() in dwarf2read.c sometimes sets the type name > using the SYMBOL_NATURAL_NAME. This is causing problems with Ada, > because contrary to C++ or Java, we chose to perform our searches using > the mangled name, not the demangled one. > > 2004-10-22 Joel Brobecker > > From Paul Hilfinger > * dwarf2read.c (new_symbol): Use SYMBOL_SEARCH_NAME rather than > SYMBOL_NATURAL_NAME to set type names. > > Tested on x86-linux. No regression. > OK to apply? -- Joel --zS7rBR6csb6tI2e1 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="dwarf2read.c.diff" Content-length: 657 Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.168 diff -u -p -r1.168 dwarf2read.c --- dwarf2read.c 19 Oct 2004 20:28:56 -0000 1.168 +++ dwarf2read.c 1 Nov 2004 19:49:49 -0000 @@ -6922,7 +6922,7 @@ new_symbol (struct die_info *die, struct this objfile, so we don't need to duplicate it for the type. */ if (TYPE_NAME (SYMBOL_TYPE (sym)) == 0) - TYPE_NAME (SYMBOL_TYPE (sym)) = SYMBOL_NATURAL_NAME (sym); + TYPE_NAME (SYMBOL_TYPE (sym)) = SYMBOL_SEARCH_NAME (sym); add_symbol_to_list (typedef_sym, list_to_add); } } --zS7rBR6csb6tI2e1--