From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13846 invoked by alias); 1 Dec 2004 03:05:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13745 invoked from network); 1 Dec 2004 03:05:23 -0000 Received: from unknown (HELO priv-edtnes46.telusplanet.net) (199.185.220.240) by sourceware.org with SMTP; 1 Dec 2004 03:05:23 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes46.telusplanet.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20041201030522.RXFJ5494.priv-edtnes46.telusplanet.net@takamaka.act-europe.fr>; Tue, 30 Nov 2004 20:05:22 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 1256A47DA6; Tue, 30 Nov 2004 19:05:22 -0800 (PST) Date: Wed, 01 Dec 2004 03:05:00 -0000 From: Joel Brobecker To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name Message-ID: <20041201030522.GF1204@adacore.com> References: <20041022213911.GJ21300@gnat.com> <20041101195035.GJ27334@gnat.com> <16810.33923.904081.661032@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16810.33923.904081.661032@localhost.redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-12/txt/msg00002.txt.bz2 > > > 2004-10-22 Joel Brobecker > > > > > > From Paul Hilfinger > > > * dwarf2read.c (new_symbol): Use SYMBOL_SEARCH_NAME rather than > > > SYMBOL_NATURAL_NAME to set type names. > Sigh, this is a hack on top af another. Unfortunately the initial > review of the symtab Ada changes wasn't helpful. I have no choice but > to let this go in for now, however, please, start thinking of a way to > get rid of those special cases in SYMBOL_blah_NAME. Making those > become part of the language vector comes to mind. OK, I see Paul, who is the one who knows most about these symbol names issues, has already answered, so I won't comment on that (I didn't have much to say anyway :-). > Can you come up with a test case for gdb.ada that shows the problem, > and is cured by this patch? Yes, I think so. I will commit a testcase and then commit this change. Thanks for your review. -- Joel