* [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS
@ 2004-10-30 15:36 Mark Kettenis
2004-10-30 19:13 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Mark Kettenis @ 2004-10-30 15:36 UTC (permalink / raw)
To: cagney; +Cc: gdb-patches
AFAICT this member is no longer used. Now if we could remove the
frame_adjust member too we could eliminate this defenition from
tm-mips.h (and tm-alpha.h too). Looking into that now.
Andrew, is this OK?
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* mips-tdep.c (PROC_HIGH_ADDR): Remove macro.
(non_heuristic_proc_desc): Don't use PROC_HIGH_ADDR.
* config/mips/tm-mips.h (struct mips_extra_func_info): Remove
`high_addr' member.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.339
diff -u -p -r1.339 mips-tdep.c
--- mips-tdep.c 30 Oct 2004 14:31:19 -0000 1.339
+++ mips-tdep.c 30 Oct 2004 15:35:48 -0000
@@ -641,7 +641,6 @@ static int mips16_to_32_reg[8] = { 16, 1
static unsigned int heuristic_fence_post = 0;
#define PROC_LOW_ADDR(proc) ((proc)->pdr.adr) /* least address */
-#define PROC_HIGH_ADDR(proc) ((proc)->high_addr) /* upper address bound */
#define PROC_FRAME_OFFSET(proc) ((proc)->pdr.frameoffset)
#define PROC_FRAME_REG(proc) ((proc)->pdr.framereg)
#define PROC_FRAME_ADJUST(proc) ((proc)->frame_adjust)
@@ -2849,9 +2848,6 @@ non_heuristic_proc_desc (CORE_ADDR pc, C
sizeof (struct mips_extra_func_info));
PROC_LOW_ADDR (proc_desc) = pdr_pc;
- /* Only used for dummy frames. */
- PROC_HIGH_ADDR (proc_desc) = 0;
-
PROC_FRAME_OFFSET (proc_desc)
= bfd_get_32 (sec->objfile->obfd, ptr + 20);
PROC_FRAME_REG (proc_desc) = bfd_get_32 (sec->objfile->obfd,
Index: config/mips/tm-mips.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v
retrieving revision 1.63
diff -u -p -r1.63 tm-mips.h
--- config/mips/tm-mips.h 26 Oct 2004 14:13:24 -0000 1.63
+++ config/mips/tm-mips.h 30 Oct 2004 15:35:48 -0000
@@ -74,7 +74,6 @@ extern void ecoff_relocate_efi (struct s
typedef struct mips_extra_func_info
{
long numargs; /* number of args to procedure (was iopt) */
- bfd_vma high_addr; /* upper address bound */
long frame_adjust; /* offset of FP from SP (used on MIPS16) */
PDR pdr; /* Procedure descriptor record */
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS
2004-10-30 15:36 [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS Mark Kettenis
@ 2004-10-30 19:13 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2004-10-30 19:13 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
Mark Kettenis wrote:
> AFAICT this member is no longer used. Now if we could remove the
> frame_adjust member too we could eliminate this defenition from
> tm-mips.h (and tm-alpha.h too). Looking into that now.
>
> Andrew, is this OK?
Not yet, I've other change to commit first. Sorry.
Andrew
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * mips-tdep.c (PROC_HIGH_ADDR): Remove macro.
> (non_heuristic_proc_desc): Don't use PROC_HIGH_ADDR.
> * config/mips/tm-mips.h (struct mips_extra_func_info): Remove
> `high_addr' member.
>
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.339
> diff -u -p -r1.339 mips-tdep.c
> --- mips-tdep.c 30 Oct 2004 14:31:19 -0000 1.339
> +++ mips-tdep.c 30 Oct 2004 15:35:48 -0000
> @@ -641,7 +641,6 @@ static int mips16_to_32_reg[8] = { 16, 1
> static unsigned int heuristic_fence_post = 0;
>
> #define PROC_LOW_ADDR(proc) ((proc)->pdr.adr) /* least address */
> -#define PROC_HIGH_ADDR(proc) ((proc)->high_addr) /* upper address bound */
> #define PROC_FRAME_OFFSET(proc) ((proc)->pdr.frameoffset)
> #define PROC_FRAME_REG(proc) ((proc)->pdr.framereg)
> #define PROC_FRAME_ADJUST(proc) ((proc)->frame_adjust)
> @@ -2849,9 +2848,6 @@ non_heuristic_proc_desc (CORE_ADDR pc, C
> sizeof (struct mips_extra_func_info));
> PROC_LOW_ADDR (proc_desc) = pdr_pc;
>
> - /* Only used for dummy frames. */
> - PROC_HIGH_ADDR (proc_desc) = 0;
> -
> PROC_FRAME_OFFSET (proc_desc)
> = bfd_get_32 (sec->objfile->obfd, ptr + 20);
> PROC_FRAME_REG (proc_desc) = bfd_get_32 (sec->objfile->obfd,
> Index: config/mips/tm-mips.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v
> retrieving revision 1.63
> diff -u -p -r1.63 tm-mips.h
> --- config/mips/tm-mips.h 26 Oct 2004 14:13:24 -0000 1.63
> +++ config/mips/tm-mips.h 30 Oct 2004 15:35:48 -0000
> @@ -74,7 +74,6 @@ extern void ecoff_relocate_efi (struct s
> typedef struct mips_extra_func_info
> {
> long numargs; /* number of args to procedure (was iopt) */
> - bfd_vma high_addr; /* upper address bound */
> long frame_adjust; /* offset of FP from SP (used on MIPS16) */
> PDR pdr; /* Procedure descriptor record */
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-30 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-30 15:36 [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS Mark Kettenis
2004-10-30 19:13 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox