From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24271 invoked by alias); 30 Oct 2004 19:13:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24263 invoked from network); 30 Oct 2004 19:13:30 -0000 Received: from unknown (HELO localhost.redhat.com) (24.42.65.225) by sourceware.org with SMTP; 30 Oct 2004 19:13:30 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 03449129D8C; Sat, 30 Oct 2004 14:13:21 -0400 (EDT) Message-ID: <4183D9C1.70109@gnu.org> Date: Sat, 30 Oct 2004 19:13:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS References: <200410301536.i9UFaM7Z008566@elgar.sibelius.xs4all.nl> In-Reply-To: <200410301536.i9UFaM7Z008566@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00501.txt.bz2 Mark Kettenis wrote: > AFAICT this member is no longer used. Now if we could remove the > frame_adjust member too we could eliminate this defenition from > tm-mips.h (and tm-alpha.h too). Looking into that now. > > Andrew, is this OK? Not yet, I've other change to commit first. Sorry. Andrew > Index: ChangeLog > from Mark Kettenis > > * mips-tdep.c (PROC_HIGH_ADDR): Remove macro. > (non_heuristic_proc_desc): Don't use PROC_HIGH_ADDR. > * config/mips/tm-mips.h (struct mips_extra_func_info): Remove > `high_addr' member. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.339 > diff -u -p -r1.339 mips-tdep.c > --- mips-tdep.c 30 Oct 2004 14:31:19 -0000 1.339 > +++ mips-tdep.c 30 Oct 2004 15:35:48 -0000 > @@ -641,7 +641,6 @@ static int mips16_to_32_reg[8] = { 16, 1 > static unsigned int heuristic_fence_post = 0; > > #define PROC_LOW_ADDR(proc) ((proc)->pdr.adr) /* least address */ > -#define PROC_HIGH_ADDR(proc) ((proc)->high_addr) /* upper address bound */ > #define PROC_FRAME_OFFSET(proc) ((proc)->pdr.frameoffset) > #define PROC_FRAME_REG(proc) ((proc)->pdr.framereg) > #define PROC_FRAME_ADJUST(proc) ((proc)->frame_adjust) > @@ -2849,9 +2848,6 @@ non_heuristic_proc_desc (CORE_ADDR pc, C > sizeof (struct mips_extra_func_info)); > PROC_LOW_ADDR (proc_desc) = pdr_pc; > > - /* Only used for dummy frames. */ > - PROC_HIGH_ADDR (proc_desc) = 0; > - > PROC_FRAME_OFFSET (proc_desc) > = bfd_get_32 (sec->objfile->obfd, ptr + 20); > PROC_FRAME_REG (proc_desc) = bfd_get_32 (sec->objfile->obfd, > Index: config/mips/tm-mips.h > =================================================================== > RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v > retrieving revision 1.63 > diff -u -p -r1.63 tm-mips.h > --- config/mips/tm-mips.h 26 Oct 2004 14:13:24 -0000 1.63 > +++ config/mips/tm-mips.h 30 Oct 2004 15:35:48 -0000 > @@ -74,7 +74,6 @@ extern void ecoff_relocate_efi (struct s > typedef struct mips_extra_func_info > { > long numargs; /* number of args to procedure (was iopt) */ > - bfd_vma high_addr; /* upper address bound */ > long frame_adjust; /* offset of FP from SP (used on MIPS16) */ > PDR pdr; /* Procedure descriptor record */ > } >