From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13916 invoked by alias); 30 Oct 2004 15:36:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13907 invoked from network); 30 Oct 2004 15:36:25 -0000 Received: from unknown (HELO walton.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org with SMTP; 30 Oct 2004 15:36:25 -0000 Received: from elgar.sibelius.xs4all.nl (elgar.sibelius.xs4all.nl [192.168.0.2]) by walton.sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id i9UFaMnU006970; Sat, 30 Oct 2004 17:36:22 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (localhost [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6) with ESMTP id i9UFaMpl008569; Sat, 30 Oct 2004 17:36:22 +0200 (CEST) (envelope-from kettenis@elgar.sibelius.xs4all.nl) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.12.6p3/8.12.6/Submit) id i9UFaM7Z008566; Sat, 30 Oct 2004 17:36:22 +0200 (CEST) Date: Sat, 30 Oct 2004 15:36:00 -0000 Message-Id: <200410301536.i9UFaM7Z008566@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com Subject: [PATCH/RFA] Remove high_addr from mips_extra_func_info for MIPS X-SW-Source: 2004-10/txt/msg00493.txt.bz2 AFAICT this member is no longer used. Now if we could remove the frame_adjust member too we could eliminate this defenition from tm-mips.h (and tm-alpha.h too). Looking into that now. Andrew, is this OK? Mark Index: ChangeLog from Mark Kettenis * mips-tdep.c (PROC_HIGH_ADDR): Remove macro. (non_heuristic_proc_desc): Don't use PROC_HIGH_ADDR. * config/mips/tm-mips.h (struct mips_extra_func_info): Remove `high_addr' member. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.339 diff -u -p -r1.339 mips-tdep.c --- mips-tdep.c 30 Oct 2004 14:31:19 -0000 1.339 +++ mips-tdep.c 30 Oct 2004 15:35:48 -0000 @@ -641,7 +641,6 @@ static int mips16_to_32_reg[8] = { 16, 1 static unsigned int heuristic_fence_post = 0; #define PROC_LOW_ADDR(proc) ((proc)->pdr.adr) /* least address */ -#define PROC_HIGH_ADDR(proc) ((proc)->high_addr) /* upper address bound */ #define PROC_FRAME_OFFSET(proc) ((proc)->pdr.frameoffset) #define PROC_FRAME_REG(proc) ((proc)->pdr.framereg) #define PROC_FRAME_ADJUST(proc) ((proc)->frame_adjust) @@ -2849,9 +2848,6 @@ non_heuristic_proc_desc (CORE_ADDR pc, C sizeof (struct mips_extra_func_info)); PROC_LOW_ADDR (proc_desc) = pdr_pc; - /* Only used for dummy frames. */ - PROC_HIGH_ADDR (proc_desc) = 0; - PROC_FRAME_OFFSET (proc_desc) = bfd_get_32 (sec->objfile->obfd, ptr + 20); PROC_FRAME_REG (proc_desc) = bfd_get_32 (sec->objfile->obfd, Index: config/mips/tm-mips.h =================================================================== RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v retrieving revision 1.63 diff -u -p -r1.63 tm-mips.h --- config/mips/tm-mips.h 26 Oct 2004 14:13:24 -0000 1.63 +++ config/mips/tm-mips.h 30 Oct 2004 15:35:48 -0000 @@ -74,7 +74,6 @@ extern void ecoff_relocate_efi (struct s typedef struct mips_extra_func_info { long numargs; /* number of args to procedure (was iopt) */ - bfd_vma high_addr; /* upper address bound */ long frame_adjust; /* offset of FP from SP (used on MIPS16) */ PDR pdr; /* Procedure descriptor record */ }