[RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?

[RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?

[Joel Brobecker]

configure now automatically detects the type of arg3 in ptrace,
and sets PTRACE_TYPE_ARG3. But the code mostly uses the historical
PTRACE_ARG3_TYPE. I suggest we do a global search-and-replace of
the latter by the former. There are a bunch of C file that use
the old macro. Once the macro is gone, we can delete their definitions
in the config files as an obvious change.

Opinions?

List of C files that use it:

        alphabsd-nat.c
        amd64bsd-nat.c
        armnbsd-nat.c
        gdbserver/linux-low.c
        hppabsd-nat.c
        hppah-nat.c
        i386bsd-nat.c
        ia64-linux-nat.c
        inferior.h
        infptrace.c
        inftarg.c
        infttrace.c
        infttrace.h
        linux-nat.c
        lynx-nat.c
        m68kbsd-nat.c
        m68klinux-nat.c
        m88kbsd-nat.c
        mipsnbsd-nat.c
        ns32knbsd-nat.c
        ppc-linux-nat.c
        ppcnbsd-nat.c
        ppcobsd-nat.c
        shnbsd-nat.c
        sparc-nat.c
        vaxbsd-nat.c

List of config files that define it:

        config/alpha/nm-linux.h
        config/alpha/nm-osf.h
        config/i386/nm-linux64.h
        config/ia64/nm-linux.h
        config/mips/nm-linux.h
        config/nm-bsd.h
        config/nm-lynx.h
        config/nm-nbsd.h
        config/pa/nm-hppah.h
        config/powerpc/nm-aix.h
        config/powerpc/nm-ppc64-linux.h
        config/rs6000/xm-aix4.h
        config/s390/nm-linux.h
        config/sparc/nm-linux.h

Unfortunately, I will probably not be around to make that change.
But this is the kind of change a guy named cagney has become an expert
at doing. :-).

And we also need to remove it from the gdbint doc, btw.

-- 
Joel

Re: [RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?

[Andrew Cagney]

Mark,

Should PTRACE_TYPE_ARG[36] include paren vis:

#define PTRACE_TYPE_ARG3 (caddr_t)

> configure now automatically detects the type of arg3 in ptrace,
> and sets PTRACE_TYPE_ARG3. But the code mostly uses the historical
> PTRACE_ARG3_TYPE. I suggest we do a global search-and-replace of
> the latter by the former. There are a bunch of C file that use
> the old macro. Once the macro is gone, we can delete their definitions
> in the config files as an obvious change.

Agreed, both moves are pretty obvious (provided the teathing problems 
are resolved).

Andrew

> Opinions?
> 
> List of C files that use it:
> 
>         alphabsd-nat.c
>         amd64bsd-nat.c
>         armnbsd-nat.c
>         gdbserver/linux-low.c
>         hppabsd-nat.c
>         hppah-nat.c
>         i386bsd-nat.c
>         ia64-linux-nat.c
>         inferior.h
>         infptrace.c
>         inftarg.c
>         infttrace.c
>         infttrace.h
>         linux-nat.c
>         lynx-nat.c
>         m68kbsd-nat.c
>         m68klinux-nat.c
>         m88kbsd-nat.c
>         mipsnbsd-nat.c
>         ns32knbsd-nat.c
>         ppc-linux-nat.c
>         ppcnbsd-nat.c
>         ppcobsd-nat.c
>         shnbsd-nat.c
>         sparc-nat.c
>         vaxbsd-nat.c
> 
> List of config files that define it:
> 
>         config/alpha/nm-linux.h
>         config/alpha/nm-osf.h
>         config/i386/nm-linux64.h
>         config/ia64/nm-linux.h
>         config/mips/nm-linux.h
>         config/nm-bsd.h
>         config/nm-lynx.h
>         config/nm-nbsd.h
>         config/pa/nm-hppah.h
>         config/powerpc/nm-aix.h
>         config/powerpc/nm-ppc64-linux.h
>         config/rs6000/xm-aix4.h
>         config/s390/nm-linux.h
>         config/sparc/nm-linux.h
> 
> Unfortunately, I will probably not be around to make that change.
> But this is the kind of change a guy named cagney has become an expert
> at doing. :-).
> 
> And we also need to remove it from the gdbint doc, btw.
> 
> -- Joel 

Re: [RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?

[Mark Kettenis]

   Date: Wed, 11 Aug 2004 20:12:11 -0400
   From: Andrew Cagney <cagney@gnu.org>
   User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801
   X-Accept-Language: en, en-us
   Cc: gdb-patches@sources.redhat.com
   Content-Type: text/plain; charset=us-ascii; format=flowed
   X-Spam-Level: 
   X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on 
	   elgar.kettenis.dyndns.org
   X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham 
	   version=2.63

   Mark,

   Should PTRACE_TYPE_ARG[36] include paren vis:

   #define PTRACE_TYPE_ARG3 (caddr_t)

It probably shouldn't.  The autoconf AM_FUNC_SELECT_ARGS test includes
the parens, but it doesn't make any sense.

Mark