From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-35198-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 14291 invoked by alias); 12 Aug 2004 01:26:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 14274 invoked from network); 12 Aug 2004 01:26:09 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 12 Aug 2004 01:26:09 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7C1Q9e3023293
	for <gdb-patches@sources.redhat.com>; Wed, 11 Aug 2004 21:26:09 -0400
Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7C1Q8a17181;
	Wed, 11 Aug 2004 21:26:08 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id B6DC82B9D; Wed, 11 Aug 2004 20:12:11 -0400 (EDT)
Message-ID: <411AB5DB.6090009@gnu.org>
Date: Thu, 12 Aug 2004 01:26:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801
MIME-Version: 1.0
To: Joel Brobecker <brobecker@gnat.com>, Mark Kettenis <kettenis@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] s/PTRACE_ARG3_TYPE/PTRACE_TYPE_ARG3/g ?
References: <20040811220121.GF25562@gnat.com>
In-Reply-To: <20040811220121.GF25562@gnat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-08/txt/msg00429.txt.bz2

Mark,

Should PTRACE_TYPE_ARG[36] include paren vis:

#define PTRACE_TYPE_ARG3 (caddr_t)

> configure now automatically detects the type of arg3 in ptrace,
> and sets PTRACE_TYPE_ARG3. But the code mostly uses the historical
> PTRACE_ARG3_TYPE. I suggest we do a global search-and-replace of
> the latter by the former. There are a bunch of C file that use
> the old macro. Once the macro is gone, we can delete their definitions
> in the config files as an obvious change.

Agreed, both moves are pretty obvious (provided the teathing problems 
are resolved).

Andrew

> Opinions?
> 
> List of C files that use it:
> 
>         alphabsd-nat.c
>         amd64bsd-nat.c
>         armnbsd-nat.c
>         gdbserver/linux-low.c
>         hppabsd-nat.c
>         hppah-nat.c
>         i386bsd-nat.c
>         ia64-linux-nat.c
>         inferior.h
>         infptrace.c
>         inftarg.c
>         infttrace.c
>         infttrace.h
>         linux-nat.c
>         lynx-nat.c
>         m68kbsd-nat.c
>         m68klinux-nat.c
>         m88kbsd-nat.c
>         mipsnbsd-nat.c
>         ns32knbsd-nat.c
>         ppc-linux-nat.c
>         ppcnbsd-nat.c
>         ppcobsd-nat.c
>         shnbsd-nat.c
>         sparc-nat.c
>         vaxbsd-nat.c
> 
> List of config files that define it:
> 
>         config/alpha/nm-linux.h
>         config/alpha/nm-osf.h
>         config/i386/nm-linux64.h
>         config/ia64/nm-linux.h
>         config/mips/nm-linux.h
>         config/nm-bsd.h
>         config/nm-lynx.h
>         config/nm-nbsd.h
>         config/pa/nm-hppah.h
>         config/powerpc/nm-aix.h
>         config/powerpc/nm-ppc64-linux.h
>         config/rs6000/xm-aix4.h
>         config/s390/nm-linux.h
>         config/sparc/nm-linux.h
> 
> Unfortunately, I will probably not be around to make that change.
> But this is the kind of change a guy named cagney has become an expert
> at doing. :-).
> 
> And we also need to remove it from the gdbint doc, btw.
> 
> -- Joel