From: Mark Kettenis <kettenis@chello.nl>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa/hppa] Use frame pointer for unwinding
Date: Sun, 16 May 2004 10:36:00 -0000 [thread overview]
Message-ID: <200405161036.i4GAaKgg002503@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040516020703.GZ566@tausq.org>
Date: Sat, 15 May 2004 19:07:03 -0700
From: Randolph Chung <randolph@tausq.org>
- if (frame_pc_unwind (next_frame) >= prologue_end)
+ if (get_frame_type (next_frame) == NORMAL_FRAME
+ && u->Save_SP
+ && (fp = frame_unwind_register_unsigned (next_frame, HPPA_FP_REGNUM)))
+ {
+ cache->base = fp;
Randolph, this patch has a major style problem: assignments within an
if-statement are frowned upon. Can you fix that?
Thanks,
Mark
next prev parent reply other threads:[~2004-05-16 10:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-16 2:07 Randolph Chung
2004-05-16 10:36 ` Mark Kettenis [this message]
2004-05-16 15:36 ` Randolph Chung
2004-05-16 16:22 ` Mark Kettenis
2004-05-16 16:42 ` Randolph Chung
2004-05-16 16:32 ` Andrew Cagney
2004-05-16 17:03 ` Randolph Chung
2004-05-17 0:13 ` Randolph Chung
2004-05-17 2:34 ` Randolph Chung
2004-05-17 15:23 ` Andrew Cagney
2004-05-17 16:01 ` Randolph Chung
2004-05-17 17:27 ` Andrew Cagney
2004-05-17 15:13 ` Andrew Cagney
2004-05-17 16:13 John David Anglin
2004-05-17 17:14 John David Anglin
2004-05-17 17:28 ` Randolph Chung
2004-05-17 17:54 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405161036.i4GAaKgg002503@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox