From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kettenis <kettenis@chello.nl>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa/hppa] Use frame pointer for unwinding
Date: Sun, 16 May 2004 10:36:00 -0000
Message-id: <200405161036.i4GAaKgg002503@elgar.kettenis.dyndns.org>
References: <20040516020703.GZ566@tausq.org>
X-SW-Source: 2004-05/msg00464.html

   Date: Sat, 15 May 2004 19:07:03 -0700
   From: Randolph Chung <randolph@tausq.org>


   -    if (frame_pc_unwind (next_frame) >= prologue_end)
   +    if (get_frame_type (next_frame) == NORMAL_FRAME
   +        && u->Save_SP 
   +	&& (fp = frame_unwind_register_unsigned (next_frame, HPPA_FP_REGNUM)))
   +      {
   +	cache->base = fp;

Randolph, this patch has a major style problem: assignments within an
if-statement are frowned upon.  Can you fix that?

Thanks,

Mark