Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Randolph Chung <tausq@debian.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa/hppa] Use frame pointer for unwinding
Date: Mon, 17 May 2004 17:27:00 -0000	[thread overview]
Message-ID: <40A8F5F6.9000704@gnu.org> (raw)
In-Reply-To: <20040517160124.GV566@tausq.org>

>+    if (frame_pc_unwind (next_frame) >= prologue_end
>+        && u->Save_SP && fp != 0)

fp will effectively always be non-zero here, so the ``fp != 0'' is a 
just-in-case?  Suggest adding that, and the GCC bug-number, as additions 
to the comments.


ok. there is no gcc bug yet, but i will file one.

the fp != 0 is there probably because i don't understand correctly how
the unwinder is working. if you have three frames:
frame 3 - unwind from here
frame 2 - doesn't save fp; fp should be constant in this function
frame 1 - saves fp
frame 3 gets frame 2 as next_frame, will it be able to get the value of
fp (from what is saved in frame 1)? it seems to work in my tests, but 
i haven't yet figured out how it works in the code. if frame 2 doesn't
(I'm assuming that the above stack backtrace is in reverse order to what 
GDB would display)

save a register in its cache, is there some code that by default 
propagates the values from the next frame?
yes, if frame-2 didn't save fp, then the trad-frame code will assume 
that frame-3's fp value is frame-2's fp value, and there for ask frame-1 
to unwind it (a recursive call).

Andrew




  reply	other threads:[~2004-05-17 17:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16  2:07 Randolph Chung
2004-05-16 10:36 ` Mark Kettenis
2004-05-16 15:36   ` Randolph Chung
2004-05-16 16:22     ` Mark Kettenis
2004-05-16 16:42       ` Randolph Chung
2004-05-16 16:32 ` Andrew Cagney
2004-05-16 17:03   ` Randolph Chung
2004-05-17  0:13     ` Randolph Chung
2004-05-17  2:34       ` Randolph Chung
2004-05-17 15:23         ` Andrew Cagney
2004-05-17 16:01           ` Randolph Chung
2004-05-17 17:27             ` Andrew Cagney [this message]
2004-05-17 15:13     ` Andrew Cagney
2004-05-17 16:13 John David Anglin
2004-05-17 17:14 John David Anglin
2004-05-17 17:28 ` Randolph Chung
2004-05-17 17:54   ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A8F5F6.9000704@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tausq@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox