[RFA/testsuite] Fix failures in observer.exp

[RFA/testsuite] Fix failures in observer.exp

[Joel Brobecker]

A recent change in the normal_stop observer caused a change in
the profile of observer_notify_normal_stop(). The observer.exp
testcase makes calls to this function, so it should be updated
accordingly.

2004-04-16  Joel Brobecker  <brobecker@gnat.com>

        * gdb.gdb/observer.exp (test_normal_stop_notifications): Update
        call to observer_notify_normal_stop.

Fixes all the failures during that test. Yah!
Ok to commit?

Thanks,
-- 
Joel

Re: [RFA/testsuite] Fix failures in observer.exp

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

[sorry, resent with the patch, this time. Sigh]

A recent change in the normal_stop observer caused a change in
the profile of observer_notify_normal_stop(). The observer.exp
testcase makes calls to this function, so it should be updated
accordingly.

2004-04-16  Joel Brobecker  <brobecker@gnat.com>

        * gdb.gdb/observer.exp (test_normal_stop_notifications): Update
        call to observer_notify_normal_stop.

Fixes all the failures during that test. Yah!
Ok to commit?
 
Thanks,
-- 
Joel

[-- Attachment #2: observer.exp.diff --]
[-- Type: text/plain, Size: 860 bytes --]

Index: observer.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.gdb/observer.exp,v
retrieving revision 1.2
diff -u -p -r1.2 observer.exp
--- observer.exp	30 Aug 2003 04:58:21 -0000	1.2
+++ observer.exp	16 Apr 2004 17:06:39 -0000
@@ -153,7 +153,10 @@ proc reset_counters { } {
 
 proc test_normal_stop_notifications { first second third message } {
     reset_counters
-    gdb_test "call observer_notify_normal_stop ()" "" \
+    # Call observer_notify_normal_stop. Note that this procedure
+    # takes one argument, but this argument is ignored by the observer
+    # callbacks we have installed. So we just pass an arbitrary value.
+    gdb_test "call observer_notify_normal_stop (0)" "" \
              "sending notification ($message)"
     check_counters $first $second $third $message
 }

Re: [RFA/testsuite] Fix failures in observer.exp

[Daniel Jacobowitz]

On Fri, Apr 16, 2004 at 10:17:19AM -0700, Joel Brobecker wrote:
> +    # Call observer_notify_normal_stop. Note that this procedure
> +    # takes one argument, but this argument is ignored by the observer
> +    # callbacks we have installed. So we just pass an arbitrary value.
> +    gdb_test "call observer_notify_normal_stop (0)" "" \

Full stops get two spaces.  Otherwise obviously OK.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA/testsuite] Fix failures in observer.exp

[Joel Brobecker]

> > +    # Call observer_notify_normal_stop. Note that this procedure
> > +    # takes one argument, but this argument is ignored by the observer
> > +    # callbacks we have installed. So we just pass an arbitrary value.
> > +    gdb_test "call observer_notify_normal_stop (0)" "" \
> 
> Full stops get two spaces.  Otherwise obviously OK.

Grrr, I can't believe I made this mistake! Fixed and checked in.

Thank you!
-- 
Joel