From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 695 invoked by alias); 16 Apr 2004 17:17:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 685 invoked from network); 16 Apr 2004 17:17:19 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 16 Apr 2004 17:17:19 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 5A2B347D63; Fri, 16 Apr 2004 10:17:19 -0700 (PDT) Date: Fri, 16 Apr 2004 17:17:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] Fix failures in observer.exp Message-ID: <20040416171719.GF22414@gnat.com> References: <20040416171410.GE22414@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="tjCHc7DPkfUGtrlw" Content-Disposition: inline In-Reply-To: <20040416171410.GE22414@gnat.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00362.txt.bz2 --tjCHc7DPkfUGtrlw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 499 [sorry, resent with the patch, this time. Sigh] A recent change in the normal_stop observer caused a change in the profile of observer_notify_normal_stop(). The observer.exp testcase makes calls to this function, so it should be updated accordingly. 2004-04-16 Joel Brobecker * gdb.gdb/observer.exp (test_normal_stop_notifications): Update call to observer_notify_normal_stop. Fixes all the failures during that test. Yah! Ok to commit? Thanks, -- Joel --tjCHc7DPkfUGtrlw Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="observer.exp.diff" Content-length: 860 Index: observer.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.gdb/observer.exp,v retrieving revision 1.2 diff -u -p -r1.2 observer.exp --- observer.exp 30 Aug 2003 04:58:21 -0000 1.2 +++ observer.exp 16 Apr 2004 17:06:39 -0000 @@ -153,7 +153,10 @@ proc reset_counters { } { proc test_normal_stop_notifications { first second third message } { reset_counters - gdb_test "call observer_notify_normal_stop ()" "" \ + # Call observer_notify_normal_stop. Note that this procedure + # takes one argument, but this argument is ignored by the observer + # callbacks we have installed. So we just pass an arbitrary value. + gdb_test "call observer_notify_normal_stop (0)" "" \ "sending notification ($message)" check_counters $first $second $third $message } --tjCHc7DPkfUGtrlw--