From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite] Fix failures in observer.exp
Date: Fri, 16 Apr 2004 17:17:00 -0000 [thread overview]
Message-ID: <20040416171719.GF22414@gnat.com> (raw)
In-Reply-To: <20040416171410.GE22414@gnat.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
[sorry, resent with the patch, this time. Sigh]
A recent change in the normal_stop observer caused a change in
the profile of observer_notify_normal_stop(). The observer.exp
testcase makes calls to this function, so it should be updated
accordingly.
2004-04-16 Joel Brobecker <brobecker@gnat.com>
* gdb.gdb/observer.exp (test_normal_stop_notifications): Update
call to observer_notify_normal_stop.
Fixes all the failures during that test. Yah!
Ok to commit?
Thanks,
--
Joel
[-- Attachment #2: observer.exp.diff --]
[-- Type: text/plain, Size: 860 bytes --]
Index: observer.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.gdb/observer.exp,v
retrieving revision 1.2
diff -u -p -r1.2 observer.exp
--- observer.exp 30 Aug 2003 04:58:21 -0000 1.2
+++ observer.exp 16 Apr 2004 17:06:39 -0000
@@ -153,7 +153,10 @@ proc reset_counters { } {
proc test_normal_stop_notifications { first second third message } {
reset_counters
- gdb_test "call observer_notify_normal_stop ()" "" \
+ # Call observer_notify_normal_stop. Note that this procedure
+ # takes one argument, but this argument is ignored by the observer
+ # callbacks we have installed. So we just pass an arbitrary value.
+ gdb_test "call observer_notify_normal_stop (0)" "" \
"sending notification ($message)"
check_counters $first $second $third $message
}
next prev parent reply other threads:[~2004-04-16 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 17:14 Joel Brobecker
2004-04-16 17:17 ` Joel Brobecker [this message]
2004-04-16 17:19 ` Daniel Jacobowitz
2004-04-16 17:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416171719.GF22414@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox