From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: Joel Brobecker <brobecker@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c
Date: Tue, 06 Apr 2004 17:54:00 -0000 [thread overview]
Message-ID: <20040406175411.GA19407@nevyn.them.org> (raw)
In-Reply-To: <4072ED55.6010007@gnu.org>
On Tue, Apr 06, 2004 at 01:48:05PM -0400, Andrew Cagney wrote:
> >- || in_prologue (stop_pc, ecs->stop_func_start))
> >- && !IN_SOLIB_RETURN_TRAMPOLINE (stop_pc, ecs->stop_func_name))
> >- || IN_SOLIB_CALL_TRAMPOLINE (stop_pc, ecs->stop_func_name)
> >- || ecs->stop_func_name == 0)
> >+ if (frame_id_eq (get_frame_id (get_prev_frame (get_current_frame ())),
> >+ step_frame_id))
>
> based on other discussion, I suspect the test will need to be:
>
> if (frame_id_inner (this_frame_id, step_frame_id)
> || frame_id_eq (....))
>
> the former is to handle a signal delivery that resumed the inferior at
> the signal handler and not the signal trampoline.
Won't anywhere you do that frame_id_inner test add another breakage for
sigaltstack?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-04-06 17:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 23:38 Ulrich Weigand
2004-03-31 21:49 ` Andrew Cagney
2004-04-02 20:50 ` Andrew Cagney
2004-04-02 23:57 ` Joel Brobecker
2004-04-03 0:08 ` Joel Brobecker
2004-04-03 1:01 ` Andrew Cagney
2004-04-06 1:48 ` Joel Brobecker
2004-04-06 16:21 ` Joel Brobecker
2004-04-06 17:48 ` Andrew Cagney
2004-04-06 17:54 ` Daniel Jacobowitz [this message]
2004-04-06 18:11 ` Andrew Cagney
2004-04-06 23:33 ` Andrew Cagney
2004-04-29 22:46 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2004-03-16 18:57 Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-21 22:38 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040406175411.GA19407@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@gnat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox