From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22238 invoked by alias); 6 Apr 2004 17:54:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22185 invoked from network); 6 Apr 2004 17:54:17 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 6 Apr 2004 17:54:17 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1BAum4-00053k-Ia; Tue, 06 Apr 2004 13:54:12 -0400 Date: Tue, 06 Apr 2004 17:54:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c Message-ID: <20040406175411.GA19407@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Joel Brobecker , gdb-patches@sources.redhat.com References: <200403292338.BAA16799@faui1d.informatik.uni-erlangen.de> <406DD226.1080104@gnu.org> <20040403000855.GF871@gnat.com> <406E0CEA.7040906@gnu.org> <20040406014818.GN871@gnat.com> <20040406162150.GT871@gnat.com> <4072ED55.6010007@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4072ED55.6010007@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-04/txt/msg00148.txt.bz2 On Tue, Apr 06, 2004 at 01:48:05PM -0400, Andrew Cagney wrote: > >- || in_prologue (stop_pc, ecs->stop_func_start)) > >- && !IN_SOLIB_RETURN_TRAMPOLINE (stop_pc, ecs->stop_func_name)) > >- || IN_SOLIB_CALL_TRAMPOLINE (stop_pc, ecs->stop_func_name) > >- || ecs->stop_func_name == 0) > >+ if (frame_id_eq (get_frame_id (get_prev_frame (get_current_frame ())), > >+ step_frame_id)) > > based on other discussion, I suspect the test will need to be: > > if (frame_id_inner (this_frame_id, step_frame_id) > || frame_id_eq (....)) > > the former is to handle a signal delivery that resumed the inferior at > the signal handler and not the signal trampoline. Won't anywhere you do that frame_id_inner test add another breakage for sigaltstack? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer