Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: gdb-patches@sources.redhat.com
Cc: Joel Brobecker <brobecker@gnat.com>
Subject: Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c
Date: Thu, 29 Apr 2004 22:46:00 -0000	[thread overview]
Message-ID: <409185B1.50001@gnu.org> (raw)
In-Reply-To: <20040406014818.GN871@gnat.com>

> Andrew,

I've bitten the bullet and committed this.  As Joel observes, failures 
are revealing latent bugs.

Andrew

>>>> >Just to make sure we're talking about the same patch, attached is the
>>>> >patch I was working on (may need to be updated to the current sources).
>>>> >Is that what you were refering to?
>>
>>> 
>>> Yes, but no longer worry about the if(legacy_frame_p) path.
> 
> 
> I have tested the attached patch on several platforms, and as expected,
> found a few regression here and there. I started analyzing the
> regressions on hp/ux, but this takes time, and I have to do something
> else for a while. A quick glance doesn't say much about the source of
> regressions, but my feeling after the few ones that I analyzed is that
> they are a consequence of a latent bug somewhere else more than a
> problem with the patch itself.  The fact that we have no regression on
> both x86-linux and sparc-solaris is also encouraging. 
> 
> Below is a quick summary of the difference in the testsuite results
> before and after the patch. It sounded like this patch would make your
> life much easier. I'll let you and the other maintainers decide whether
> it's acceptable to include this patch now, as a small step backward to
> allow you to jump farther.



  parent reply	other threads:[~2004-04-29 22:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-29 23:38 Ulrich Weigand
2004-03-31 21:49 ` Andrew Cagney
2004-04-02 20:50 ` Andrew Cagney
2004-04-02 23:57   ` Joel Brobecker
2004-04-03  0:08   ` Joel Brobecker
2004-04-03  1:01     ` Andrew Cagney
2004-04-06  1:48       ` Joel Brobecker
2004-04-06 16:21         ` Joel Brobecker
2004-04-06 17:48           ` Andrew Cagney
2004-04-06 17:54             ` Daniel Jacobowitz
2004-04-06 18:11               ` Andrew Cagney
2004-04-06 23:33                 ` Andrew Cagney
2004-04-29 22:46         ` Andrew Cagney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-16 18:57 Andrew Cagney
2004-03-19  0:09 ` Andrew Cagney
2004-03-21 22:38 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=409185B1.50001@gnu.org \
    --to=cagney@gnu.org \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox