From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>,
gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Use frame_type for sigtramp test in infrun.c
Date: Fri, 02 Apr 2004 23:57:00 -0000 [thread overview]
Message-ID: <20040402235722.GE871@gnat.com> (raw)
In-Reply-To: <406DD226.1080104@gnu.org>
> Joel, from memory you had a change to:
>
> if (((stop_pc == ecs->stop_func_start /* Quick test */
> || in_prologue (stop_pc, ecs->stop_func_start))
> && !IN_SOLIB_RETURN_TRAMPOLINE (stop_pc, ecs->stop_func_name))
> || IN_SOLIB_CALL_TRAMPOLINE (stop_pc, ecs->stop_func_name)
> || ecs->stop_func_name == 0)
> {
> /* It's a subroutine call. */
> handle_step_into_function (ecs);
> return;
> }
>
> pending? If we do pull the sigtramp code I think it would be prudent to
> first have that committed - Joel's change greatly clarifies the logic.
Yes. Something that would isolate this code to the platforms who haven't
been framified yet (are there still any?). But the problem is that I
got some regressions mostly on HP/UX, but also one on Tru64. The
testsuite results were clean on sparc-solaris and x86-linux.
The problem was that it was difficult for me to investigate the problems
on HP/UX given the current status. So I started looking at the current
failures on HP/UX to see if I could improve them a bit.
I should probably redo some testing and see where we stand. Yeah, let
me do that.
--
Joel
next prev parent reply other threads:[~2004-04-02 23:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 23:38 Ulrich Weigand
2004-03-31 21:49 ` Andrew Cagney
2004-04-02 20:50 ` Andrew Cagney
2004-04-02 23:57 ` Joel Brobecker [this message]
2004-04-03 0:08 ` Joel Brobecker
2004-04-03 1:01 ` Andrew Cagney
2004-04-06 1:48 ` Joel Brobecker
2004-04-06 16:21 ` Joel Brobecker
2004-04-06 17:48 ` Andrew Cagney
2004-04-06 17:54 ` Daniel Jacobowitz
2004-04-06 18:11 ` Andrew Cagney
2004-04-06 23:33 ` Andrew Cagney
2004-04-29 22:46 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2004-03-16 18:57 Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-21 22:38 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040402235722.GE871@gnat.com \
--to=brobecker@gnat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox