* Strange change to read_namespace
@ 2004-03-27 17:10 Daniel Jacobowitz
2004-03-29 16:51 ` David Carlton
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2004-03-27 17:10 UTC (permalink / raw)
To: carlton, gdb-patches
When you checked in this patch:
2004-03-15 David Carlton <carlton@kealia.com>
Fix for PR c++/1553:
* dwarf2read.c (read_structure_type): Determine type name by
calling determine_class_name.
(determine_class_name): New.
(determine_prefix): Look at TYPE_TAG_NAME and call
determine_class_name when appropriate.
(determine_prefix_aux, class_name): Delete.
You also checked in this:
@@ -3724,6 +3717,7 @@ read_namespace (struct die_info *die, st
TYPE_TAG_NAME (type) = TYPE_NAME (type);
new_symbol (die, type, cu);
+ die->type = type;
if (is_anonymous)
cp_add_using_directive (processing_current_prefix,
Did you mean to do that? It seems plausible.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Strange change to read_namespace
2004-03-27 17:10 Strange change to read_namespace Daniel Jacobowitz
@ 2004-03-29 16:51 ` David Carlton
0 siblings, 0 replies; 2+ messages in thread
From: David Carlton @ 2004-03-29 16:51 UTC (permalink / raw)
To: gdb-patches
On Sat, 27 Mar 2004 12:10:44 -0500, Daniel Jacobowitz <drow@false.org> said:
> When you checked in this patch:
> 2004-03-15 David Carlton <carlton@kealia.com>
> Fix for PR c++/1553:
> * dwarf2read.c (read_structure_type): Determine type name by
> calling determine_class_name.
> (determine_class_name): New.
> (determine_prefix): Look at TYPE_TAG_NAME and call
> determine_class_name when appropriate.
> (determine_prefix_aux, class_name): Delete.
> You also checked in this:
> @@ -3724,6 +3717,7 @@ read_namespace (struct die_info *die, st
> TYPE_TAG_NAME (type) = TYPE_NAME (type);
> new_symbol (die, type, cu);
> + die->type = type;
> if (is_anonymous)
> cp_add_using_directive (processing_current_prefix,
> Did you mean to do that? It seems plausible.
Whoops, sorry, I guess that slipped through the ChangeLog. Yes, I
meant to do that: that's so that determine_prefix can check to see if
the die it's trying to find the prefix for has a type and, if so, look
at its TYPE_TAG_NAME.
I'll go and update that ChangeLog entry:
(read_namespace): Set die->type.
David Carlton
carlton@kealia.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-29 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-27 17:10 Strange change to read_namespace Daniel Jacobowitz
2004-03-29 16:51 ` David Carlton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox