From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23422 invoked by alias); 29 Mar 2004 16:51:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23401 invoked from network); 29 Mar 2004 16:51:42 -0000 Received: from unknown (HELO hawaii.kealia.com) (209.3.10.89) by sources.redhat.com with SMTP; 29 Mar 2004 16:51:42 -0000 Received: by hawaii.kealia.com (Postfix, from userid 2049) id 0DA59C6C3; Mon, 29 Mar 2004 08:51:42 -0800 (PST) To: gdb-patches@sources.redhat.com Subject: Re: Strange change to read_namespace References: <20040327171044.GA9440@nevyn.them.org> From: David Carlton Date: Mon, 29 Mar 2004 16:51:00 -0000 In-Reply-To: <20040327171044.GA9440@nevyn.them.org> (Daniel Jacobowitz's message of "Sat, 27 Mar 2004 12:10:44 -0500") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Reasonable Discussion, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-03/txt/msg00720.txt.bz2 On Sat, 27 Mar 2004 12:10:44 -0500, Daniel Jacobowitz said: > When you checked in this patch: > 2004-03-15 David Carlton > Fix for PR c++/1553: > * dwarf2read.c (read_structure_type): Determine type name by > calling determine_class_name. > (determine_class_name): New. > (determine_prefix): Look at TYPE_TAG_NAME and call > determine_class_name when appropriate. > (determine_prefix_aux, class_name): Delete. > You also checked in this: > @@ -3724,6 +3717,7 @@ read_namespace (struct die_info *die, st > TYPE_TAG_NAME (type) = TYPE_NAME (type); > new_symbol (die, type, cu); > + die->type = type; > if (is_anonymous) > cp_add_using_directive (processing_current_prefix, > Did you mean to do that? It seems plausible. Whoops, sorry, I guess that slipped through the ChangeLog. Yes, I meant to do that: that's so that determine_prefix can check to see if the die it's trying to find the prefix for has a type and, if so, look at its TYPE_TAG_NAME. I'll go and update that ChangeLog entry: (read_namespace): Set die->type. David Carlton carlton@kealia.com