From: David Carlton <carlton@kealia.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Strange change to read_namespace
Date: Mon, 29 Mar 2004 16:51:00 -0000 [thread overview]
Message-ID: <yf2r7vbtx42.fsf@hawaii.kealia.com> (raw)
In-Reply-To: <20040327171044.GA9440@nevyn.them.org> (Daniel Jacobowitz's message of "Sat, 27 Mar 2004 12:10:44 -0500")
On Sat, 27 Mar 2004 12:10:44 -0500, Daniel Jacobowitz <drow@false.org> said:
> When you checked in this patch:
> 2004-03-15 David Carlton <carlton@kealia.com>
> Fix for PR c++/1553:
> * dwarf2read.c (read_structure_type): Determine type name by
> calling determine_class_name.
> (determine_class_name): New.
> (determine_prefix): Look at TYPE_TAG_NAME and call
> determine_class_name when appropriate.
> (determine_prefix_aux, class_name): Delete.
> You also checked in this:
> @@ -3724,6 +3717,7 @@ read_namespace (struct die_info *die, st
> TYPE_TAG_NAME (type) = TYPE_NAME (type);
> new_symbol (die, type, cu);
> + die->type = type;
> if (is_anonymous)
> cp_add_using_directive (processing_current_prefix,
> Did you mean to do that? It seems plausible.
Whoops, sorry, I guess that slipped through the ChangeLog. Yes, I
meant to do that: that's so that determine_prefix can check to see if
the die it's trying to find the prefix for has a type and, if so, look
at its TYPE_TAG_NAME.
I'll go and update that ChangeLog entry:
(read_namespace): Set die->type.
David Carlton
carlton@kealia.com
prev parent reply other threads:[~2004-03-29 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-27 17:10 Daniel Jacobowitz
2004-03-29 16:51 ` David Carlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yf2r7vbtx42.fsf@hawaii.kealia.com \
--to=carlton@kealia.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox