Re: [patch/CRIS] Prologue scan bug fixes, return_value implementation

[Daniel Jacobowitz <drow@false.org>]

On Wed, Mar 03, 2004 at 05:40:09PM +0100, Orjan Friberg wrote:
> The patch below improves the CRIS prologue scanner by, at least partially, 
> handling the case when the PC is still in the prologue, which takes care of 
> 14 FAILs in recurse.exp and 2 FAILs in step-test.exp.  I've also added a 
> return_value implementation which gets rid of 32 FAILs and 30 KFAILs in 
> structs.exp.  (All tests in those test cases now PASS.)
> 
> Ok to commit to trunk and 6.1 branch?

As Andrew mentioned, you're the listed maintainer of the CRIS port -
you don't need approval for changes to CRIS-specific files.  I think
that at this point it's appropriate for the branch also.

> +/* Handle the CRIS return value convention.  */
> +
> +static enum return_value_convention
> +cris_return_value (struct gdbarch *gdbarch, struct type *type,
> +		   struct regcache *regcache, void *readbuf,
> +		   const void *writebuf)
> +{
> +  if (TYPE_CODE (type) == TYPE_CODE_STRUCT ||
> +      TYPE_CODE (type) == TYPE_CODE_UNION ||
> +      TYPE_LENGTH (type) > 8)

Style nit: || at the beginning of the line, please.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer