Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Orjan Friberg <orjan.friberg@axis.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/CRIS] Prologue scan bug fixes, return_value implementation
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <40460ED4.4040201@axis.com> (raw)
In-Reply-To: <20040303164450.GA18032@nevyn.them.org>

Daniel Jacobowitz wrote:
> 
> As Andrew mentioned, you're the listed maintainer of the CRIS port -
> you don't need approval for changes to CRIS-specific files.  I think
> that at this point it's appropriate for the branch also.

Ah, ok.  I'm being overly cautious.  Thanks for the clarification.

>>+  if (TYPE_CODE (type) == TYPE_CODE_STRUCT ||
>>+      TYPE_CODE (type) == TYPE_CODE_UNION ||
>>+      TYPE_LENGTH (type) > 8)
> 
> 
> Style nit: || at the beginning of the line, please.

Thanks for noticing; will fix before commit.

-- 
Orjan Friberg
Axis Communications



WARNING: multiple messages have this Message-ID

From: Orjan Friberg <orjan.friberg@axis.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/CRIS] Prologue scan bug fixes, return_value implementation
Date: Wed, 03 Mar 2004 16:59:00 -0000	[thread overview]
Message-ID: <40460ED4.4040201@axis.com> (raw)
Message-ID: <20040303165900.l5wV5RtYHL0usWYed8yuuEHiB0eNIzDsfw-m_fCJ1mE@z> (raw)
In-Reply-To: <20040303164450.GA18032@nevyn.them.org>

Daniel Jacobowitz wrote:
> 
> As Andrew mentioned, you're the listed maintainer of the CRIS port -
> you don't need approval for changes to CRIS-specific files.  I think
> that at this point it's appropriate for the branch also.

Ah, ok.  I'm being overly cautious.  Thanks for the clarification.

>>+  if (TYPE_CODE (type) == TYPE_CODE_STRUCT ||
>>+      TYPE_CODE (type) == TYPE_CODE_UNION ||
>>+      TYPE_LENGTH (type) > 8)
> 
> 
> Style nit: || at the beginning of the line, please.

Thanks for noticing; will fix before commit.

-- 
Orjan Friberg
Axis Communications



  reply	other threads:[~2004-03-03 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Orjan Friberg
2004-03-03 16:40 ` Orjan Friberg
2004-03-03 16:44 ` Daniel Jacobowitz
2004-03-19  0:09   ` Orjan Friberg [this message]
2004-03-03 16:59     ` Orjan Friberg
2004-03-19  0:09     ` Andrew Cagney
2004-03-03 18:47       ` Andrew Cagney
2004-03-04  9:23       ` Orjan Friberg
2004-03-19  0:09         ` Orjan Friberg
2004-03-19  0:09   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40460ED4.4040201@axis.com \
    --to=orjan.friberg@axis.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox