From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29457 invoked by alias); 3 Mar 2004 16:44:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29448 invoked from network); 3 Mar 2004 16:44:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 3 Mar 2004 16:44:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AyZUI-0004iK-F5; Wed, 03 Mar 2004 11:44:50 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: Orjan Friberg Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/CRIS] Prologue scan bug fixes, return_value implementation Message-ID: <20040303164450.GA18032@nevyn.them.org> Mail-Followup-To: Orjan Friberg , gdb-patches@sources.redhat.com References: <40460A69.2060600@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40460A69.2060600@axis.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00046.txt.bz2 Message-ID: <20040319000900.BzTslYpHMC5nG6dwDbWrqt-2uMO0l8YDEbVJz_Ik0gM@z> On Wed, Mar 03, 2004 at 05:40:09PM +0100, Orjan Friberg wrote: > The patch below improves the CRIS prologue scanner by, at least partially, > handling the case when the PC is still in the prologue, which takes care of > 14 FAILs in recurse.exp and 2 FAILs in step-test.exp. I've also added a > return_value implementation which gets rid of 32 FAILs and 30 KFAILs in > structs.exp. (All tests in those test cases now PASS.) > > Ok to commit to trunk and 6.1 branch? As Andrew mentioned, you're the listed maintainer of the CRIS port - you don't need approval for changes to CRIS-specific files. I think that at this point it's appropriate for the branch also. > +/* Handle the CRIS return value convention. */ > + > +static enum return_value_convention > +cris_return_value (struct gdbarch *gdbarch, struct type *type, > + struct regcache *regcache, void *readbuf, > + const void *writebuf) > +{ > + if (TYPE_CODE (type) == TYPE_CODE_STRUCT || > + TYPE_CODE (type) == TYPE_CODE_UNION || > + TYPE_LENGTH (type) > 8) Style nit: || at the beginning of the line, please. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer