Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <20040310182000.GA20405@nevyn.them.org> (raw)
In-Reply-To: <20040310175446.GR25204@cygbert.vinschen.de>

On Wed, Mar 10, 2004 at 06:54:46PM +0100, Corinna Vinschen wrote:
> On Mar 10 11:37, Daniel Jacobowitz wrote:
> > What's the one symbol with just one underscore?
> 
>     _ZZN9__gnu_cxx27__verbose_terminate_handlerEvE11terminating

I can't see any reason for that to be special-cased, so this may be a
GCC bug.

> I have a revised patch to solve the GDB problem.  The leading_char
> is removed right before the call to SYMBOL_SET_NAMES.  The same
> functionality is removed from install_minimal_symbols entirely.
> I tested on i686-pc-linux with gcc 3.3 and sh-elf with gcc 3.4.
> 
> The testsuite has 48 less FAILs on sh-elf, all in gdb.cp.
> 
> The testsuite has one FAIL more for i686-pc-linux:
> 
>   FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1)
> 
> though I must admit that I don't see what that has to do with my patch.
> 
> 
> Corinna
> 
> 
> 	* minsyms.c (install_minimal_symbols): Move dropping leading
> 	char from linkage name from here...
> 	(prim_record_minimal_symbol_and_info): ...to here.

Thanks.  I recommend this patch for symtab approval.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI
Date: Wed, 10 Mar 2004 18:20:00 -0000	[thread overview]
Message-ID: <20040310182000.GA20405@nevyn.them.org> (raw)
Message-ID: <20040310182000.Smfhbfe15874vzg0zQrdcz-dvZ8yfYkkC8sFrWtGNpc@z> (raw)
In-Reply-To: <20040310175446.GR25204@cygbert.vinschen.de>

On Wed, Mar 10, 2004 at 06:54:46PM +0100, Corinna Vinschen wrote:
> On Mar 10 11:37, Daniel Jacobowitz wrote:
> > What's the one symbol with just one underscore?
> 
>     _ZZN9__gnu_cxx27__verbose_terminate_handlerEvE11terminating

I can't see any reason for that to be special-cased, so this may be a
GCC bug.

> I have a revised patch to solve the GDB problem.  The leading_char
> is removed right before the call to SYMBOL_SET_NAMES.  The same
> functionality is removed from install_minimal_symbols entirely.
> I tested on i686-pc-linux with gcc 3.3 and sh-elf with gcc 3.4.
> 
> The testsuite has 48 less FAILs on sh-elf, all in gdb.cp.
> 
> The testsuite has one FAIL more for i686-pc-linux:
> 
>   FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1)
> 
> though I must admit that I don't see what that has to do with my patch.
> 
> 
> Corinna
> 
> 
> 	* minsyms.c (install_minimal_symbols): Move dropping leading
> 	char from linkage name from here...
> 	(prim_record_minimal_symbol_and_info): ...to here.

Thanks.  I recommend this patch for symtab approval.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  parent reply	other threads:[~2004-03-10 18:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Corinna Vinschen
2004-03-10 10:57 ` Corinna Vinschen
2004-03-19  0:09 ` Jim Blandy
2004-03-10 15:04   ` Jim Blandy
2004-03-19  0:09 ` Daniel Jacobowitz
2004-03-10 15:08   ` Daniel Jacobowitz
2004-03-10 15:55   ` Corinna Vinschen
2004-03-10 16:04     ` Daniel Jacobowitz
2004-03-10 16:16       ` Corinna Vinschen
2004-03-19  0:09         ` Daniel Jacobowitz
2004-03-10 16:20           ` Daniel Jacobowitz
2004-03-19  0:09           ` Corinna Vinschen
2004-03-10 16:34             ` Corinna Vinschen
2004-03-10 16:37             ` Daniel Jacobowitz
2004-03-10 17:54               ` Corinna Vinschen
2004-03-10 18:02                 ` David Carlton
2004-03-19  0:09                   ` David Carlton
2004-03-10 18:23                 ` Corinna Vinschen
2004-03-19  0:09                   ` Corinna Vinschen
2004-03-22 17:34                   ` Corinna Vinschen
2004-03-22 17:38                     ` Corinna Vinschen
2004-03-25 20:44                   ` Jim Blandy
2004-03-26 13:57                     ` Corinna Vinschen
2004-03-26 17:54                       ` Eli Zaretskii
2004-03-28 18:28                       ` Jim Blandy
2004-03-29 11:26                         ` Corinna Vinschen
2004-03-19  0:09                 ` Corinna Vinschen
2004-03-19  0:09                 ` Ian Lance Taylor
2004-03-10 18:30                   ` Ian Lance Taylor
2004-03-19  0:09                   ` Corinna Vinschen
2004-03-10 18:46                     ` Corinna Vinschen
2004-03-10 19:02                     ` Ian Lance Taylor
2004-03-19  0:09                       ` Ian Lance Taylor
2004-03-19  0:09                 ` Daniel Jacobowitz [this message]
2004-03-10 18:20                   ` Daniel Jacobowitz
2004-03-19  0:09               ` Daniel Jacobowitz
2004-03-10 16:43             ` Corinna Vinschen
2004-03-10 16:46               ` Daniel Jacobowitz
2004-03-19  0:09                 ` Daniel Jacobowitz
2004-03-19  0:09               ` Corinna Vinschen
2004-03-19  0:09         ` Corinna Vinschen
2004-03-19  0:09       ` Daniel Jacobowitz
2004-03-19  0:09     ` Corinna Vinschen
  -- strict thread matches above, loose matches on Subject: below --
2004-03-10 18:03 Michael Elizabeth Chastain
2004-03-19  0:09 ` Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040310182000.GA20405@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox