From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17611 invoked by alias); 10 Mar 2004 18:20:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17604 invoked from network); 10 Mar 2004 18:20:01 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 10 Mar 2004 18:20:01 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B18JF-0005Kx-28 for ; Wed, 10 Mar 2004 13:20:01 -0500 Date: Wed, 10 Mar 2004 18:20:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310182000.GA20405@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> <20040310163716.GA2114@nevyn.them.org> <20040310175446.GR25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310175446.GR25204@cygbert.vinschen.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03.o/txt/msg00244.txt Message-ID: <20040310182000.Smfhbfe15874vzg0zQrdcz-dvZ8yfYkkC8sFrWtGNpc@z> On Wed, Mar 10, 2004 at 06:54:46PM +0100, Corinna Vinschen wrote: > On Mar 10 11:37, Daniel Jacobowitz wrote: > > What's the one symbol with just one underscore? > > _ZZN9__gnu_cxx27__verbose_terminate_handlerEvE11terminating I can't see any reason for that to be special-cased, so this may be a GCC bug. > I have a revised patch to solve the GDB problem. The leading_char > is removed right before the call to SYMBOL_SET_NAMES. The same > functionality is removed from install_minimal_symbols entirely. > I tested on i686-pc-linux with gcc 3.3 and sh-elf with gcc 3.4. > > The testsuite has 48 less FAILs on sh-elf, all in gdb.cp. > > The testsuite has one FAIL more for i686-pc-linux: > > FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1) > > though I must admit that I don't see what that has to do with my patch. > > > Corinna > > > * minsyms.c (install_minimal_symbols): Move dropping leading > char from linkage name from here... > (prim_record_minimal_symbol_and_info): ...to here. Thanks. I recommend this patch for symtab approval. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer