From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI
Date: Wed, 10 Mar 2004 16:46:00 -0000 [thread overview]
Message-ID: <20040310164617.GA2684@nevyn.them.org> (raw)
In-Reply-To: <20040310164335.GQ25204@cygbert.vinschen.de>
On Wed, Mar 10, 2004 at 05:43:35PM +0100, Corinna Vinschen wrote:
> On Mar 10 17:34, Corinna Vinschen wrote:
> > On Mar 10 11:20, Daniel Jacobowitz wrote:
> > > Move the check earlier? It should not be necessary to change
> > > SYMBOL_LINKAGE_NAME. I think you could do this in
> > > prim_record_minimal_symbol_and_info at the call site of
> > > SYMBOL_SET_NAMES.
> >
> > I'm more and more under the impression that the problem is raised due
> > to a bug in the symbol generation in gcc. It doesn't seem worth to
> > change GDB proactively...
>
> Wait a second. If the symbols actually begin with _Z as they do e.g. on
> Linux, then the test we're talking about would fail on Linx, too, if...
> yes, if leading_char would be "_" on Linux as well. But on Linux the
> leading_char is \0.
>
> So, it looks like the actual problem is, that SYMBOL_SET_NAMES is
> called in prim_record_minimal_symbol_and_info, without having stripped
> the leading_char from the symbol names.
Right. I think that this has been a problem for a long time, but
I made it worse somehow with the introduction of SYMBOL_SET_NAMES.
> That doesn't explain why there's one symbol which has no leading _
> but that would make sense for all other mangled symbols given in the
> object file, right?
Precisely.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040310164617.GA2684@nevyn.them.org> (raw)
Message-ID: <20040319000900.XgcE3-XnjsiJsoTlx8opz7zdbpjHrFWNbwQradyC_9Y@z> (raw)
In-Reply-To: <20040310164335.GQ25204@cygbert.vinschen.de>
On Wed, Mar 10, 2004 at 05:43:35PM +0100, Corinna Vinschen wrote:
> On Mar 10 17:34, Corinna Vinschen wrote:
> > On Mar 10 11:20, Daniel Jacobowitz wrote:
> > > Move the check earlier? It should not be necessary to change
> > > SYMBOL_LINKAGE_NAME. I think you could do this in
> > > prim_record_minimal_symbol_and_info at the call site of
> > > SYMBOL_SET_NAMES.
> >
> > I'm more and more under the impression that the problem is raised due
> > to a bug in the symbol generation in gcc. It doesn't seem worth to
> > change GDB proactively...
>
> Wait a second. If the symbols actually begin with _Z as they do e.g. on
> Linux, then the test we're talking about would fail on Linx, too, if...
> yes, if leading_char would be "_" on Linux as well. But on Linux the
> leading_char is \0.
>
> So, it looks like the actual problem is, that SYMBOL_SET_NAMES is
> called in prim_record_minimal_symbol_and_info, without having stripped
> the leading_char from the symbol names.
Right. I think that this has been a problem for a long time, but
I made it worse somehow with the introduction of SYMBOL_SET_NAMES.
> That doesn't explain why there's one symbol which has no leading _
> but that would make sense for all other mangled symbols given in the
> object file, right?
Precisely.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-03-10 16:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Corinna Vinschen
2004-03-10 10:57 ` Corinna Vinschen
2004-03-19 0:09 ` Jim Blandy
2004-03-10 15:04 ` Jim Blandy
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 15:08 ` Daniel Jacobowitz
2004-03-10 15:55 ` Corinna Vinschen
2004-03-10 16:04 ` Daniel Jacobowitz
2004-03-10 16:16 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 16:20 ` Daniel Jacobowitz
2004-03-19 0:09 ` Corinna Vinschen
2004-03-10 16:34 ` Corinna Vinschen
2004-03-10 16:37 ` Daniel Jacobowitz
2004-03-10 17:54 ` Corinna Vinschen
2004-03-10 18:02 ` David Carlton
2004-03-19 0:09 ` David Carlton
2004-03-10 18:23 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
2004-03-22 17:34 ` Corinna Vinschen
2004-03-22 17:38 ` Corinna Vinschen
2004-03-25 20:44 ` Jim Blandy
2004-03-26 13:57 ` Corinna Vinschen
2004-03-26 17:54 ` Eli Zaretskii
2004-03-28 18:28 ` Jim Blandy
2004-03-29 11:26 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
2004-03-19 0:09 ` Ian Lance Taylor
2004-03-10 18:30 ` Ian Lance Taylor
2004-03-19 0:09 ` Corinna Vinschen
2004-03-10 18:46 ` Corinna Vinschen
2004-03-10 19:02 ` Ian Lance Taylor
2004-03-19 0:09 ` Ian Lance Taylor
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 18:20 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 16:43 ` Corinna Vinschen
2004-03-10 16:46 ` Daniel Jacobowitz [this message]
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Corinna Vinschen
-- strict thread matches above, loose matches on Subject: below --
2004-03-10 18:03 Michael Elizabeth Chastain
2004-03-19 0:09 ` Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040310164617.GA2684@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox