From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20199 invoked by alias); 10 Mar 2004 16:46:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20174 invoked from network); 10 Mar 2004 16:46:17 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 10 Mar 2004 16:46:17 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B16qX-0000hj-Ac for ; Wed, 10 Mar 2004 11:46:17 -0500 Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040310164617.GA2684@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> <20040310164335.GQ25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310164335.GQ25204@cygbert.vinschen.de> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00238.txt.bz2 Message-ID: <20040319000900.XgcE3-XnjsiJsoTlx8opz7zdbpjHrFWNbwQradyC_9Y@z> On Wed, Mar 10, 2004 at 05:43:35PM +0100, Corinna Vinschen wrote: > On Mar 10 17:34, Corinna Vinschen wrote: > > On Mar 10 11:20, Daniel Jacobowitz wrote: > > > Move the check earlier? It should not be necessary to change > > > SYMBOL_LINKAGE_NAME. I think you could do this in > > > prim_record_minimal_symbol_and_info at the call site of > > > SYMBOL_SET_NAMES. > > > > I'm more and more under the impression that the problem is raised due > > to a bug in the symbol generation in gcc. It doesn't seem worth to > > change GDB proactively... > > Wait a second. If the symbols actually begin with _Z as they do e.g. on > Linux, then the test we're talking about would fail on Linx, too, if... > yes, if leading_char would be "_" on Linux as well. But on Linux the > leading_char is \0. > > So, it looks like the actual problem is, that SYMBOL_SET_NAMES is > called in prim_record_minimal_symbol_and_info, without having stripped > the leading_char from the symbol names. Right. I think that this has been a problem for a long time, but I made it worse somehow with the introduction of SYMBOL_SET_NAMES. > That doesn't explain why there's one symbol which has no leading _ > but that would make sense for all other mangled symbols given in the > object file, right? Precisely. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer