Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com, cagney@gnu.org
Subject: Re: [rfa/target/doc] Print less with "set debug target 1"
Date: Sun, 07 Mar 2004 05:39:00 -0000	[thread overview]
Message-ID: <3791-Sun07Mar2004073738+0200-eliz@elta.co.il> (raw)
Message-ID: <20040307053900.pVGZr9Rzy6qJNtOw64jaBVsssh8lEfLN5k8Q9u-g810@z> (raw)
In-Reply-To: <20040306230834.GA9343@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 6 Mar 2004 18:08:35 -0500)

> Date: Sat, 6 Mar 2004 18:08:35 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> Seem OK?

Thanks for the documentation patch, but I have 2 minor comments:

>  @item set debug target
>  Turns on or off display of @value{GDBN} target debugging info. This info
>  includes what is going on at the target level of GDB, as it happens. The
> -default is off.
> +default is 0.  Set it to 1 to track events, and to 2 to also track the
> +value of large memory transfers.  This flag must be set before connecting
> +to the target or saying @code{run}.

  . I'm not sure I understand this sentence--do you mean to say that
    _if_ the flag is set, it must be set _before_ connecting and
    before "run"?  If so, I suggest to use @emph and/or @strong to
    make sure the reader understands you, and maybe rephrase slightly
    to make sure the wording is less ambiguous.

  . Since in this context "run" is something the user types, it
    should be @kbd{run}, not @code{run}.

Otherwise, it is okay to go in.


  parent reply	other threads:[~2004-03-07  5:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Daniel Jacobowitz
2004-03-06 23:08 ` Daniel Jacobowitz
2004-03-08 22:49 ` Michael Snyder
2004-03-19  0:09   ` Michael Snyder
2004-03-09 16:18 ` Daniel Jacobowitz
2004-03-19  0:09   ` Eli Zaretskii
2004-03-09 19:39     ` Daniel Jacobowitz
2004-03-19  0:09       ` Daniel Jacobowitz
2004-03-09 19:39     ` Eli Zaretskii
2004-03-19  0:09   ` Daniel Jacobowitz
2004-03-19  0:09 ` Eli Zaretskii [this message]
2004-03-07  5:39   ` Eli Zaretskii
2004-03-09  0:12   ` Andrew Cagney
2004-03-19  0:09     ` Andrew Cagney
2004-03-19  0:09   ` Michael Snyder
2004-03-08 22:48     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3791-Sun07Mar2004073738+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox