From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [ob] Remove initializations of memset'd structure
Date: Tue, 17 Feb 2004 20:44:00 -0000 [thread overview]
Message-ID: <20040217204404.GA5744@nevyn.them.org> (raw)
In-Reply-To: <16434.30825.567879.693173@localhost.redhat.com>
On Tue, Feb 17, 2004 at 03:24:09PM -0500, Elena Zannoni wrote:
> I am not sure I follow your sentence. If you are worried that the
> value 0 can indicate a perfectly legal msymbol, this is no different
> from the situation we end up with when just using the memset. You can
> always add a new enum value of mst_bogus (pick your name) and use that
> in the terminating msym. BTW, there is almost identical code in
> minsyms.c:install_minimal_symbols.
Nothing important. My only point was that anything which read the type
of this minimal symbol was already off the end of the array, because
mst_unknown does not act as a terminator; everything should either use
minimal_symbol_count (most things do), or SYMBOL_LINKAGE_NAME (msym) ==
NULL. So there is no need for the type to be mst_unknown (or anything
else).
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2004-02-17 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 21:15 Daniel Jacobowitz
2004-02-17 6:54 ` Eli Zaretskii
2004-02-17 14:34 ` Elena Zannoni
2004-02-17 19:12 ` Eli Zaretskii
2004-02-17 19:37 ` Elena Zannoni
2004-02-17 19:47 ` Daniel Jacobowitz
2004-02-17 20:28 ` Elena Zannoni
2004-02-17 20:44 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040217204404.GA5744@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox