From: Elena Zannoni <ezannoni@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sources.redhat.com
Subject: Re: [ob] Remove initializations of memset'd structure
Date: Tue, 17 Feb 2004 14:34:00 -0000 [thread overview]
Message-ID: <16434.9582.574401.561988@localhost.redhat.com> (raw)
In-Reply-To: <uk72m2o25.fsf@elta.co.il>
Eli Zaretskii writes:
> > Date: Mon, 16 Feb 2004 16:15:16 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> >
> > - MSYMBOL_TYPE (m) = mst_unknown;
>
> This part of the patch seems to assume that mst_unknown has the value
> zero. Should we have such assumptions in the code?
Yes, in symtab.h mst_unknown is 0. However, that got me puzzled as
well, and I think it warrants a comment. Daniel, please add something
in the function you touched.
elena
next prev parent reply other threads:[~2004-02-17 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 21:15 Daniel Jacobowitz
2004-02-17 6:54 ` Eli Zaretskii
2004-02-17 14:34 ` Elena Zannoni [this message]
2004-02-17 19:12 ` Eli Zaretskii
2004-02-17 19:37 ` Elena Zannoni
2004-02-17 19:47 ` Daniel Jacobowitz
2004-02-17 20:28 ` Elena Zannoni
2004-02-17 20:44 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16434.9582.574401.561988@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=drow@false.org \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox