From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-30763-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 10926 invoked by alias); 17 Feb 2004 14:34:21 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 10919 invoked from network); 17 Feb 2004 14:34:20 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 17 Feb 2004 14:34:20 -0000
Received: by localhost.redhat.com (Postfix, from userid 469)
	id C33181A448A; Tue, 17 Feb 2004 09:30:06 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16434.9582.574401.561988@localhost.redhat.com>
Date: Tue, 17 Feb 2004 14:34:00 -0000
To: Eli Zaretskii <eliz@elta.co.il>
Cc: Daniel Jacobowitz <drow@false.org>,
	gdb-patches@sources.redhat.com
Subject: Re: [ob] Remove initializations of memset'd structure
In-Reply-To: <uk72m2o25.fsf@elta.co.il>
References: <20040216211516.GA17055@nevyn.them.org>
	<uk72m2o25.fsf@elta.co.il>
X-SW-Source: 2004-02/txt/msg00463.txt.bz2

Eli Zaretskii writes:
 > > Date: Mon, 16 Feb 2004 16:15:16 -0500
 > > From: Daniel Jacobowitz <drow@false.org>
 > >  
 > > -    MSYMBOL_TYPE (m) = mst_unknown;
 > 
 > This part of the patch seems to assume that mst_unknown has the value
 > zero.  Should we have such assumptions in the code?

Yes, in symtab.h mst_unknown is 0. However, that got me puzzled as
well, and I think it warrants a comment. Daniel, please add something
in the function you touched.

elena