From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2162 invoked by alias); 17 Feb 2004 20:44:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2155 invoked from network); 17 Feb 2004 20:44:04 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Feb 2004 20:44:04 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AtC4a-0001VL-DY for ; Tue, 17 Feb 2004 15:44:04 -0500 Date: Tue, 17 Feb 2004 20:44:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [ob] Remove initializations of memset'd structure Message-ID: <20040217204404.GA5744@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040216211516.GA17055@nevyn.them.org> <16434.9582.574401.561988@localhost.redhat.com> <2914-Tue17Feb2004211147+0200-eliz@elta.co.il> <16434.27783.373959.570693@localhost.redhat.com> <20040217194659.GA32474@nevyn.them.org> <16434.30825.567879.693173@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16434.30825.567879.693173@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00484.txt.bz2 On Tue, Feb 17, 2004 at 03:24:09PM -0500, Elena Zannoni wrote: > I am not sure I follow your sentence. If you are worried that the > value 0 can indicate a perfectly legal msymbol, this is no different > from the situation we end up with when just using the memset. You can > always add a new enum value of mst_bogus (pick your name) and use that > in the terminating msym. BTW, there is almost identical code in > minsyms.c:install_minimal_symbols. Nothing important. My only point was that anything which read the type of this minimal symbol was already off the end of the array, because mst_unknown does not act as a terminator; everything should either use minimal_symbol_count (most things do), or SYMBOL_LINKAGE_NAME (msym) == NULL. So there is no need for the type to be mst_unknown (or anything else). -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer