Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Fix "make install" for Info files
@ 2004-01-21 11:30 Eli Zaretskii
  2004-01-21 15:16 ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2004-01-21 11:30 UTC (permalink / raw)
  To: gdb-patches

The change below is required for "make install" to DTRT when running
`install-info' after installing the Info files, in case DESTDIR is
set to something other than the empty string.

Okay to commit?  I'd say it's ob-ish (and bfd/doc/Makefile.in does it
exactly as I did below), but...

2004-01-21  Eli Zaretskii  <eliz@elta.co.il>

	* Makefile.in (install-info): Prepend $(DESTDIR) to $(infodir).

--- gdb/doc/Makefile.i~0	2003-08-08 17:30:36.000000000 +0200
+++ gdb/doc/Makefile.in	2004-01-21 12:06:44.000000000 +0200
@@ -171,8 +171,8 @@
 	@if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
 	  list='$(INFO_DEPS)'; \
 	  for file in $$list; do \
-	    echo " install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file";\
-	    install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
+	    echo " install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file";\
+	    install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
 	  done; \
 	else : ; fi
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix "make install" for Info files
  2004-01-21 11:30 [RFA] Fix "make install" for Info files Eli Zaretskii
@ 2004-01-21 15:16 ` Daniel Jacobowitz
  2004-01-21 18:48   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2004-01-21 15:16 UTC (permalink / raw)
  To: gdb-patches

On Wed, Jan 21, 2004 at 01:31:03PM +0200, Eli Zaretskii wrote:
> The change below is required for "make install" to DTRT when running
> `install-info' after installing the Info files, in case DESTDIR is
> set to something other than the empty string.
> 
> Okay to commit?  I'd say it's ob-ish (and bfd/doc/Makefile.in does it
> exactly as I did below), but...

I'd agree with you - not to mention that you could approve it yourself
even if it weren't.  It is definitely correct.

> 
> 2004-01-21  Eli Zaretskii  <eliz@elta.co.il>
> 
> 	* Makefile.in (install-info): Prepend $(DESTDIR) to $(infodir).
> 
> --- gdb/doc/Makefile.i~0	2003-08-08 17:30:36.000000000 +0200
> +++ gdb/doc/Makefile.in	2004-01-21 12:06:44.000000000 +0200
> @@ -171,8 +171,8 @@
>  	@if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
>  	  list='$(INFO_DEPS)'; \
>  	  for file in $$list; do \
> -	    echo " install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file";\
> -	    install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
> +	    echo " install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file";\
> +	    install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
>  	  done; \
>  	else : ; fi
>  
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix "make install" for Info files
  2004-01-21 15:16 ` Daniel Jacobowitz
@ 2004-01-21 18:48   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2004-01-21 18:48 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: gdb-patches

> Date: Wed, 21 Jan 2004 10:16:23 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
> 
> I'd agree with you - not to mention that you could approve it yourself
> even if it weren't.  It is definitely correct.

I wanted another pair of eyes to glance over that--the configury
stuff is sometimes tricky.

Thanks, committed.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-01-21 18:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-21 11:30 [RFA] Fix "make install" for Info files Eli Zaretskii
2004-01-21 15:16 ` Daniel Jacobowitz
2004-01-21 18:48   ` Eli Zaretskii

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox