From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-30095-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 32538 invoked by alias); 21 Jan 2004 15:16:25 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32524 invoked from network); 21 Jan 2004 15:16:24 -0000
Received: from unknown (HELO nevyn.them.org) (66.93.172.17)
  by sources.redhat.com with SMTP; 21 Jan 2004 15:16:24 -0000
Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian))
	id 1AjK5f-0000JR-T0
	for <gdb-patches@sources.redhat.com>; Wed, 21 Jan 2004 10:16:23 -0500
Date: Wed, 21 Jan 2004 15:16:00 -0000
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix "make install" for Info files
Message-ID: <20040121151623.GA1131@nevyn.them.org>
Mail-Followup-To: gdb-patches@sources.redhat.com
References: <uvfn5o7wo.fsf@elta.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <uvfn5o7wo.fsf@elta.co.il>
User-Agent: Mutt/1.5.1i
X-SW-Source: 2004-01/txt/msg00580.txt.bz2

On Wed, Jan 21, 2004 at 01:31:03PM +0200, Eli Zaretskii wrote:
> The change below is required for "make install" to DTRT when running
> `install-info' after installing the Info files, in case DESTDIR is
> set to something other than the empty string.
> 
> Okay to commit?  I'd say it's ob-ish (and bfd/doc/Makefile.in does it
> exactly as I did below), but...

I'd agree with you - not to mention that you could approve it yourself
even if it weren't.  It is definitely correct.

> 
> 2004-01-21  Eli Zaretskii  <eliz@elta.co.il>
> 
> 	* Makefile.in (install-info): Prepend $(DESTDIR) to $(infodir).
> 
> --- gdb/doc/Makefile.i~0	2003-08-08 17:30:36.000000000 +0200
> +++ gdb/doc/Makefile.in	2004-01-21 12:06:44.000000000 +0200
> @@ -171,8 +171,8 @@
>  	@if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
>  	  list='$(INFO_DEPS)'; \
>  	  for file in $$list; do \
> -	    echo " install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file";\
> -	    install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
> +	    echo " install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file";\
> +	    install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
>  	  done; \
>  	else : ; fi
>  
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer