Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix "make install" for Info files
Date: Wed, 21 Jan 2004 15:16:00 -0000	[thread overview]
Message-ID: <20040121151623.GA1131@nevyn.them.org> (raw)
In-Reply-To: <uvfn5o7wo.fsf@elta.co.il>

On Wed, Jan 21, 2004 at 01:31:03PM +0200, Eli Zaretskii wrote:
> The change below is required for "make install" to DTRT when running
> `install-info' after installing the Info files, in case DESTDIR is
> set to something other than the empty string.
> 
> Okay to commit?  I'd say it's ob-ish (and bfd/doc/Makefile.in does it
> exactly as I did below), but...

I'd agree with you - not to mention that you could approve it yourself
even if it weren't.  It is definitely correct.

> 
> 2004-01-21  Eli Zaretskii  <eliz@elta.co.il>
> 
> 	* Makefile.in (install-info): Prepend $(DESTDIR) to $(infodir).
> 
> --- gdb/doc/Makefile.i~0	2003-08-08 17:30:36.000000000 +0200
> +++ gdb/doc/Makefile.in	2004-01-21 12:06:44.000000000 +0200
> @@ -171,8 +171,8 @@
>  	@if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \
>  	  list='$(INFO_DEPS)'; \
>  	  for file in $$list; do \
> -	    echo " install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file";\
> -	    install-info --info-dir=$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
> +	    echo " install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file";\
> +	    install-info --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/$$file || :;\
>  	  done; \
>  	else : ; fi
>  
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-21 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-21 11:30 Eli Zaretskii
2004-01-21 15:16 ` Daniel Jacobowitz [this message]
2004-01-21 18:48   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040121151623.GA1131@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox