Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: RFA/ARM: Switch mode when setting PC
Date: Sat, 17 Jan 2004 18:54:00 -0000	[thread overview]
Message-ID: <20040117185436.GA9089@nevyn.them.org> (raw)
In-Reply-To: <40095EFD.4030609@gnu.org>

On Sat, Jan 17, 2004 at 11:12:45AM -0500, Andrew Cagney wrote:
> 
> >>If there's an explicit "set_resume_address", separate to write_pc, this 
> >>should happen:
> >>
> >>	(gdb) set $r15 = 0x123
> >>	- target sees:
> >>		$r15=0x123
> >>	(gdb) call foo()   OR (gdb) jump foo
> >>	- target, via "set_resume_address", sees:
> >>		$r15=&foo
> >>		$ps&|=<magic-bits>
> >>
> >>and significantly no other write_pc calls.
> >
> >
> >And at this point, is write_pc used for anything besides
> >DECR_PC_AFTER_BREAK?
> 
> Hopefully not (well ignoring -tdep files).

That's my thought too.

> > I would prefer to add an adjust_pc_after_break,
> >and then possibly rename the existing write_pc.  Most of the write_pc
> >implementations we have currently are really set-resume-address
> >semantics.
> 
> The change wouldn't be tested, and would be more work.

What wouldn't be tested?  I have this handy DECR_PC_AFTER_BREAK target
machine to test on... in fact, I have access to m68k, alpha, s390,
i386, and a d10v simulator.  Definitely more work, though.

I've now begun work on the cleanup of DECR_PC_AFTER_BREAK in a local
tree.  More to follow.  It's going to require painful testing...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-17 18:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-16  3:54 Daniel Jacobowitz
2004-01-16  5:43 ` Andrew Cagney
2004-01-16 14:10   ` Daniel Jacobowitz
2004-01-16 14:15     ` Richard Earnshaw
2004-01-16 14:26       ` Daniel Jacobowitz
2004-01-16 14:34       ` Richard Earnshaw
2004-01-16 14:41         ` Daniel Jacobowitz
2004-01-16 15:00           ` Richard Earnshaw
2004-01-16 15:56             ` Daniel Jacobowitz
2004-01-16 16:55               ` Richard Earnshaw
2004-01-16 17:11                 ` Daniel Jacobowitz
2004-01-16 17:28                   ` Richard Earnshaw
2004-01-16 19:12                     ` Andrew Cagney
2004-01-16 17:32     ` Daniel Jacobowitz
2004-01-16 18:57       ` Andrew Cagney
2004-01-17  4:58         ` Daniel Jacobowitz
2004-01-17 10:49           ` Richard Earnshaw
2004-01-17 16:36             ` Andrew Cagney
2004-01-17 16:12           ` Andrew Cagney
2004-01-17 18:54             ` Daniel Jacobowitz [this message]
2004-01-17 21:59 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040117185436.GA9089@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox