From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3641 invoked by alias); 17 Jan 2004 18:54:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3634 invoked from network); 17 Jan 2004 18:54:38 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Jan 2004 18:54:38 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Ahvae-0008R4-WF for ; Sat, 17 Jan 2004 13:54:36 -0500 Date: Sat, 17 Jan 2004 18:54:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFA/ARM: Switch mode when setting PC Message-ID: <20040117185436.GA9089@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200401161727.i0GHRxt24387@pc960.cambridge.arm.com> <40083792.7020102@gnu.org> <20040116035402.GA3215@nevyn.them.org> <40077A12.5040306@gnu.org> <20040116141040.GA8134@nevyn.them.org> <20040116173235.GA7498@nevyn.them.org> <40083424.1000102@gnu.org> <20040117045843.GA31115@nevyn.them.org> <40095EFD.4030609@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40095EFD.4030609@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00445.txt.bz2 On Sat, Jan 17, 2004 at 11:12:45AM -0500, Andrew Cagney wrote: > > >>If there's an explicit "set_resume_address", separate to write_pc, this > >>should happen: > >> > >> (gdb) set $r15 = 0x123 > >> - target sees: > >> $r15=0x123 > >> (gdb) call foo() OR (gdb) jump foo > >> - target, via "set_resume_address", sees: > >> $r15=&foo > >> $ps&|= > >> > >>and significantly no other write_pc calls. > > > > > >And at this point, is write_pc used for anything besides > >DECR_PC_AFTER_BREAK? > > Hopefully not (well ignoring -tdep files). That's my thought too. > > I would prefer to add an adjust_pc_after_break, > >and then possibly rename the existing write_pc. Most of the write_pc > >implementations we have currently are really set-resume-address > >semantics. > > The change wouldn't be tested, and would be more work. What wouldn't be tested? I have this handy DECR_PC_AFTER_BREAK target machine to test on... in fact, I have access to m68k, alpha, s390, i386, and a d10v simulator. Definitely more work, though. I've now begun work on the cleanup of DECR_PC_AFTER_BREAK in a local tree. More to follow. It's going to require painful testing... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer