Re: [rfa:symtab] deprecate inside_entry_func

[Daniel Jacobowitz <drow@mvista.com>]

On Fri, Nov 21, 2003 at 02:53:42PM -0500, Andrew Cagney wrote:
> >Hello,
> >
> >This patch deprecates the function inside_entry_func.
> >
> >PS: Ref: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00533.html
> 
> Here's a revised patch.  It now eliminates the [disabled] 
> inside_entry_func call from "get_prev_frame", replacing it with the more 
> direct [but equally disabled] get_frame_func() == entry_point_address() 
> test.  This way all calls to inside_entry_func have been eliminated from 
> up-to-date code.
> 
> Thoughts? Symtab ok?
> 
> Andrew
> 

What Kevin and I have both repeatedly suggested, I think, is:
  - Do not deprecate inside_entry_func; fix it if you don't like the
    way it is implemented.  Change the implementation.
  - Deprecate entry_func_lowpc and entry_func_highpc (there's a typo in
    your changelog, two lowpc's) if you really want to deprecate
    something.

The concept of inside_entry_func does not seem to be deprecated, so why
rename it?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer