From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28542 invoked by alias); 21 Nov 2003 19:59:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28535 invoked from network); 21 Nov 2003 19:59:49 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 21 Nov 2003 19:59:49 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1ANHRV-0000DZ-EH; Fri, 21 Nov 2003 14:59:49 -0500 Date: Fri, 21 Nov 2003 19:59:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa:symtab] deprecate inside_entry_func Message-ID: <20031121195949.GA794@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <3FA2F940.5040102@redhat.com> <3FBE6D46.4070201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FBE6D46.4070201@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00442.txt.bz2 On Fri, Nov 21, 2003 at 02:53:42PM -0500, Andrew Cagney wrote: > >Hello, > > > >This patch deprecates the function inside_entry_func. > > > >PS: Ref: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00533.html > > Here's a revised patch. It now eliminates the [disabled] > inside_entry_func call from "get_prev_frame", replacing it with the more > direct [but equally disabled] get_frame_func() == entry_point_address() > test. This way all calls to inside_entry_func have been eliminated from > up-to-date code. > > Thoughts? Symtab ok? > > Andrew > What Kevin and I have both repeatedly suggested, I think, is: - Do not deprecate inside_entry_func; fix it if you don't like the way it is implemented. Change the implementation. - Deprecate entry_func_lowpc and entry_func_highpc (there's a typo in your changelog, two lowpc's) if you really want to deprecate something. The concept of inside_entry_func does not seem to be deprecated, so why rename it? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer