Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>, Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:symtab] deprecate inside_entry_func
Date: Fri, 21 Nov 2003 22:40:00 -0000	[thread overview]
Message-ID: <1031121224031.ZM20442@localhost.localdomain> (raw)
In-Reply-To: Daniel Jacobowitz <drow@mvista.com> "Re: [rfa:symtab] deprecate inside_entry_func" (Nov 21,  4:54pm)

On Nov 21,  4:54pm, Daniel Jacobowitz wrote:

> On Fri, Nov 21, 2003 at 02:24:16PM -0700, Kevin Buettner wrote:
> > On Nov 21,  4:04pm, Daniel Jacobowitz wrote:
> > 
> > > I imagine the third caller, in frv-tdep.c, is bogus
> > > and could be removed somehow.  But if it's going to be left there then
> > > it seems reasonable to update it also.
> > 
> > I had thought that get_prev_frame's call to inside_entry_func() had
> > been disabled pending a demonstration that it's needed.  Hmm...  I see
> > I was getting this confused with the code corresponding to
> > inside_entry_file().
> > 
> > Okay, that means that frv-tdep.c's use of inside_entry_func() can go
> > away.  I'll get rid of it.
> 
> Are you sure?
> 
>   /* NOTE: cagney/2003-07-15: Need to add a "set backtrace
>      beyond-entry-func" command so that this can be selectively
>      disabled.  */
>   if (0
> #if 0
>       && backtrace_beyond_entry_func
> #endif
>       && this_frame->type != DUMMY_FRAME && this_frame->level >= 0
>       && inside_entry_func (get_frame_pc (this_frame)))

Oops.  You're right.

(My attention was so focused on the limited scope of the ``#if 0'' that
I failed to notice the 0 in the ``if'' conditional.)

Kevin


  reply	other threads:[~2003-11-21 22:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-01  0:07 Andrew Cagney
2003-11-01  0:37 ` Kevin Buettner
2003-11-01  0:46   ` Andrew Cagney
2003-11-01  0:55     ` Kevin Buettner
2003-11-01  2:27       ` Andrew Cagney
2003-11-07 17:31         ` Kevin Buettner
2003-11-07 21:25           ` Andrew Cagney
2003-11-01  0:42 ` Daniel Jacobowitz
2003-11-01  2:37   ` Andrew Cagney
2003-11-09  0:13     ` Daniel Jacobowitz
2003-11-09  2:40       ` Andrew Cagney
2003-11-09  3:50         ` Daniel Jacobowitz
2003-11-21 19:53 ` Andrew Cagney
2003-11-21 19:59   ` Daniel Jacobowitz
2003-11-21 20:11     ` Kevin Buettner
2003-11-21 20:46     ` Andrew Cagney
2003-11-21 20:48       ` Daniel Jacobowitz
2003-11-21 20:55         ` Andrew Cagney
2003-11-21 21:04           ` Daniel Jacobowitz
2003-11-21 21:24             ` Kevin Buettner
2003-11-21 21:54               ` Daniel Jacobowitz
2003-11-21 22:40                 ` Kevin Buettner [this message]
2003-11-22  0:37             ` Andrew Cagney
2003-11-22  0:41               ` Daniel Jacobowitz
2003-11-21 20:07   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1031121224031.ZM20442@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox