From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25044 invoked by alias); 21 Nov 2003 22:40:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25031 invoked from network); 21 Nov 2003 22:40:39 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 21 Nov 2003 22:40:39 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hALMecH15996 for ; Fri, 21 Nov 2003 17:40:38 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hALMecw21213; Fri, 21 Nov 2003 17:40:38 -0500 Received: from localhost.localdomain (vpn50-29.rdu.redhat.com [172.16.50.29]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hALMeb89019387; Fri, 21 Nov 2003 17:40:37 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id hALMeW120443; Fri, 21 Nov 2003 15:40:32 -0700 Date: Fri, 21 Nov 2003 22:40:00 -0000 From: Kevin Buettner Message-Id: <1031121224031.ZM20442@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [rfa:symtab] deprecate inside_entry_func" (Nov 21, 4:54pm) References: <3FA2F940.5040102@redhat.com> <3FBE6D46.4070201@redhat.com> <20031121195949.GA794@nevyn.them.org> <3FBE79B6.2090209@redhat.com> <20031121204833.GA2356@nevyn.them.org> <3FBE7BD8.2090601@redhat.com> <20031121210412.GA2627@nevyn.them.org> <1031121212415.ZM17980@localhost.localdomain> <20031121215418.GA27420@nevyn.them.org> To: Daniel Jacobowitz , Kevin Buettner Subject: Re: [rfa:symtab] deprecate inside_entry_func Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00453.txt.bz2 On Nov 21, 4:54pm, Daniel Jacobowitz wrote: > On Fri, Nov 21, 2003 at 02:24:16PM -0700, Kevin Buettner wrote: > > On Nov 21, 4:04pm, Daniel Jacobowitz wrote: > > > > > I imagine the third caller, in frv-tdep.c, is bogus > > > and could be removed somehow. But if it's going to be left there then > > > it seems reasonable to update it also. > > > > I had thought that get_prev_frame's call to inside_entry_func() had > > been disabled pending a demonstration that it's needed. Hmm... I see > > I was getting this confused with the code corresponding to > > inside_entry_file(). > > > > Okay, that means that frv-tdep.c's use of inside_entry_func() can go > > away. I'll get rid of it. > > Are you sure? > > /* NOTE: cagney/2003-07-15: Need to add a "set backtrace > beyond-entry-func" command so that this can be selectively > disabled. */ > if (0 > #if 0 > && backtrace_beyond_entry_func > #endif > && this_frame->type != DUMMY_FRAME && this_frame->level >= 0 > && inside_entry_func (get_frame_pc (this_frame))) Oops. You're right. (My attention was so focused on the limited scope of the ``#if 0'' that I failed to notice the 0 in the ``if'' conditional.) Kevin