[rfa/testsuite] avoid 'gamma' function name

[rfa/testsuite] avoid 'gamma' function name

[Michael Elizabeth Chastain]

This patchlet works around a recent change in gcc HEAD where 'gamma' is
now a reserved identifier, even when 'math.h' is not included.

I've reported this as a regression bug against gcc:

  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12213
  [3.4 regression] warning: conflicting types for builtin-function 'gamma'

I'm pretty sure this is actually a bug in gcc.  A draft of the C9x spec
says that all external library names are reserved, and does not qualify
that by saying that the header file for that name has to be included.
However, the particular name 'gamma' is an obsolete name and not
mentioned in the standard.

However -- the purpose of gdb1250.exp is to test backtracing and
prologue analysis.  It's not to test C library reserved identifiers.
So this patch just avoids the issue.

Testing: tested on native i686-pc-linux-gnu, gcc v2 and v3, dwarf-2 and
stabs+.  Specifically tested with gcc HEAD that thinks 'gamma' is
a reserved identifier.

Okay to commit?

Michael C

===

2003-09-08  Michael Chastain  <mec@shout.net>

	* gdb.base/gdb1250.c: Rename 'gamma' to 'my_gamma'.

Index: gdb.base/gdb1250.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1250.c,v
retrieving revision 1.1
diff -u -r1.1 gdb1250.c
--- gdb.base/gdb1250.c	15 Jul 2003 16:28:21 -0000	1.1
+++ gdb.base/gdb1250.c	8 Sep 2003 21:05:19 -0000
@@ -25,7 +25,11 @@
 
 int global = 0;
 
-void gamma (int *parray)
+/* Foo, gcc thinks 'gamma' is a reserved identifier.
+   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12213
+   I am not interested in testing that point so just avoid the word.
+   -- chastain 2003-09-08. */
+void my_gamma (int *parray)
 {
   return;
 }
@@ -37,7 +41,7 @@
   array [1] = global++;
   array [2] = global++;
   array [3] = global++;
-  gamma (array);
+  my_gamma (array);
   abort ();
 }
 

Re: [rfa/testsuite] avoid 'gamma' function name

[Daniel Jacobowitz]

On Mon, Sep 08, 2003 at 05:11:57PM -0400, Michael Elizabeth Chastain wrote:
> This patchlet works around a recent change in gcc HEAD where 'gamma' is
> now a reserved identifier, even when 'math.h' is not included.
> 
> I've reported this as a regression bug against gcc:
> 
>   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12213
>   [3.4 regression] warning: conflicting types for builtin-function 'gamma'
> 
> I'm pretty sure this is actually a bug in gcc.  A draft of the C9x spec
> says that all external library names are reserved, and does not qualify
> that by saying that the header file for that name has to be included.
> However, the particular name 'gamma' is an obsolete name and not
> mentioned in the standard.
> 
> However -- the purpose of gdb1250.exp is to test backtracing and
> prologue analysis.  It's not to test C library reserved identifiers.
> So this patch just avoids the issue.
> 
> Testing: tested on native i686-pc-linux-gnu, gcc v2 and v3, dwarf-2 and
> stabs+.  Specifically tested with gcc HEAD that thinks 'gamma' is
> a reserved identifier.
> 
> Okay to commit?

Sounds reasonable to me.  I'm 99.9% sure you're right about the GCC
bug, too - at least if gcc HEAD defaults to gnu99 mode?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [rfa/testsuite] avoid 'gamma' function name

[Michael Elizabeth Chastain]

Committed.

Michael C

===

2003-09-08  Michael Chastain  <mec@shout.net>

	* gdb.base/gdb1250.c: Rename 'gamma' to 'my_gamma'.

Re: [rfa/testsuite] avoid 'gamma' function name

[Michael Elizabeth Chastain]

> Sounds reasonable to me.  I'm 99.9% sure you're right about the GCC
> bug, too - at least if gcc HEAD defaults to gnu99 mode?

gcc HEAD -std=c99 compiles my test program with 'gamma'
just fine.  So does gcc HEAD -std=c89, for that matter.

So it looks like the particular name 'gamma' is a gnu extension
and is enabled by default.  Bit my ankle, but easy to deal with.

Michael C