Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: gdb-patches@sources.redhat.com
Subject: [rfa/testsuite] avoid 'gamma' function name
Date: Mon, 08 Sep 2003 21:11:00 -0000	[thread overview]
Message-ID: <200309082111.h88LBvq6011543@duracef.shout.net> (raw)

This patchlet works around a recent change in gcc HEAD where 'gamma' is
now a reserved identifier, even when 'math.h' is not included.

I've reported this as a regression bug against gcc:

  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12213
  [3.4 regression] warning: conflicting types for builtin-function 'gamma'

I'm pretty sure this is actually a bug in gcc.  A draft of the C9x spec
says that all external library names are reserved, and does not qualify
that by saying that the header file for that name has to be included.
However, the particular name 'gamma' is an obsolete name and not
mentioned in the standard.

However -- the purpose of gdb1250.exp is to test backtracing and
prologue analysis.  It's not to test C library reserved identifiers.
So this patch just avoids the issue.

Testing: tested on native i686-pc-linux-gnu, gcc v2 and v3, dwarf-2 and
stabs+.  Specifically tested with gcc HEAD that thinks 'gamma' is
a reserved identifier.

Okay to commit?

Michael C

===

2003-09-08  Michael Chastain  <mec@shout.net>

	* gdb.base/gdb1250.c: Rename 'gamma' to 'my_gamma'.

Index: gdb.base/gdb1250.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1250.c,v
retrieving revision 1.1
diff -u -r1.1 gdb1250.c
--- gdb.base/gdb1250.c	15 Jul 2003 16:28:21 -0000	1.1
+++ gdb.base/gdb1250.c	8 Sep 2003 21:05:19 -0000
@@ -25,7 +25,11 @@
 
 int global = 0;
 
-void gamma (int *parray)
+/* Foo, gcc thinks 'gamma' is a reserved identifier.
+   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12213
+   I am not interested in testing that point so just avoid the word.
+   -- chastain 2003-09-08. */
+void my_gamma (int *parray)
 {
   return;
 }
@@ -37,7 +41,7 @@
   array [1] = global++;
   array [2] = global++;
   array [3] = global++;
-  gamma (array);
+  my_gamma (array);
   abort ();
 }
 


             reply	other threads:[~2003-09-08 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-08 21:11 Michael Elizabeth Chastain [this message]
2003-09-08 21:14 ` Daniel Jacobowitz
2003-09-08 21:29 Michael Elizabeth Chastain
2003-09-08 21:31 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200309082111.h88LBvq6011543@duracef.shout.net \
    --to=mec@shout.net \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox